Skip to content

Start a fresh proxy in proxy smoke tests #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 1 commit into from
Nov 13, 2026
Merged

Start a fresh proxy in proxy smoke tests #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions smoke-tests/tests/proxy-python.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ except urllib.error.URLError as e:
describe('python through the credential proxy (strict TLS verification)', () => {
test.skipIf(SKIP)('urllib completes a strict-verified MITM request (installed CLI)', () => {
const result = runVarlock(
['proxy', 'run', '--', PYTHON!, '-c', PYTHON_CLIENT],
['proxy', 'run', '--new', '--', PYTHON!, '-c', PYTHON_CLIENT],
{ cwd: 'smoke-test-proxy' },
);

Expand All @@ -68,7 +68,7 @@ describe('python through the credential proxy (strict TLS verification)', () =>
// The bundled/compiled binary is the risky artifact for cert generation
// (module init order differs from bun run / vitest), so prove it there too.
const result = runBinary(
['proxy', 'run', '--', PYTHON!, '-c', PYTHON_CLIENT],
['proxy', 'run', '--new', '--', PYTHON!, '-c', PYTHON_CLIENT],
{ cwd: 'smoke-test-proxy' },
);

Expand Down
4 changes: 3 additions & 1 deletion smoke-tests/tests/proxy-signals.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ const SKIP = process.platform === 'win32';
* Spawn `varlock proxy run -- <command>`, wait until the child prints a `ready` marker,
* send `signal` to the varlock process itself, and resolve once it exits.
* stdin is left non-interactive so varlock runs the child in its own process group.
* `--new` keeps it from attaching to a proxy session another test file started in the same
* fixture dir (it can be shutting down and refuse the connection).
*/
function runAndSignal(command: Array<string>, signal: NodeJS.Signals, env?: Record<string, string>) {
return new Promise<{ output: string; code: number | null; signal: NodeJS.Signals | null }>(
(resolve, reject) => {
const child = spawn(process.execPath, [VARLOCK_CLI, 'proxy', 'run', '--', ...command], {
const child = spawn(process.execPath, [VARLOCK_CLI, 'proxy', 'run', '--new', '--', ...command], {
cwd: PROXY_CWD,
stdio: ['ignore', 'pipe', 'pipe'],
env: { ...process.env, ...env },
Expand Down
Loading