Repository navigation
Fix release: stop parsing npm pack --json, pin npm 11 - #1303
Merged
Merged
Conversation
npm@latest is now npm 12, which changed npm pack --json from an array to an object keyed by package name, so fetch-native-helpers failed before publish.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the release workflow and native-helper staging fix, validating all four helpers with npm 11.15.0 and 12.2.0 in isolated fixtures.
- Output-independent packing:
fetch-native-helpers.tsextracts the single.tgzfrom its fresh per-platform directory instead of parsing npm's JSON output. - npm major constraint: The release job installs
npm@^11.15.0, retaining OIDC/provenance support without adopting npm 12.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The release run for the #1264 version merge failed in "Fetch published native helpers", before anything was published:
TypeError: {} is not iterableinscripts/fetch-native-helpers.ts.The release job installs
npm@latest, which is now npm 12. npm 12 changednpm pack --jsonfrom an array to an object keyed by package name.fetch-native-helpers.tsno longer parses that output; it packs and then takes the single.tgzfrom its own temp dir. Verified staging all four helpers with npm 11.15 and npm 12.2.npm@^11.15.0(still new enough for OIDC/provenance) so this release does not also take on an untested npm major in the publish step.No bump file on purpose: main has no pending bump files and the 1.25.0 versions are unpublished, so
bumpy ci planstays inpublishmode and merging this re-runs the publish of the existing version PR. A bump file here would flip it toversion-pr.