Skip to content

Fix release: stop parsing npm pack --json, pin npm 11 - #1303

Merged
theoephraim merged 1 commit into
mainfrom
fix-release-npm12-pack
Nov 13, 2026
Merged

theoephraim merged 1 commit into
mainfrom
fix-release-npm12-pack

Conversation

@theoephraim

Copy link
Copy Markdown
Member

The release run for the #1264 version merge failed in "Fetch published native helpers", before anything was published: TypeError: {} is not iterable in scripts/fetch-native-helpers.ts.

The release job installs npm@latest, which is now npm 12. npm 12 changed npm pack --json from an array to an object keyed by package name.

  • fetch-native-helpers.ts no longer parses that output; it packs and then takes the single .tgz from its own temp dir. Verified staging all four helpers with npm 11.15 and npm 12.2.
  • The release job pins npm@^11.15.0 (still new enough for OIDC/provenance) so this release does not also take on an untested npm major in the publish step.

No bump file on purpose: main has no pending bump files and the 1.25.0 versions are unpublished, so bumpy ci plan stays in publish mode and merging this re-runs the publish of the existing version PR. A bump file here would flip it to version-pr.

npm@latest is now npm 12, which changed npm pack --json from an array to an
object keyed by package name, so fetch-native-helpers failed before publish.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the release workflow and native-helper staging fix, validating all four helpers with npm 11.15.0 and 12.2.0 in isolated fixtures.

  • Output-independent packing: fetch-native-helpers.ts extracts the single .tgz from its fresh per-platform directory instead of parsing npm's JSON output.
  • npm major constraint: The release job installs npm@^11.15.0, retaining OIDC/provenance support without adopting npm 12.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@theoephraim
theoephraim merged commit f6cc593 into main Nov 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant