Skip to content

Fix release: stop parsing npm pack --json, pin npm 11 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 1 commit into from
Nov 13, 2026
Merged

Fix release: stop parsing npm pack --json, pin npm 11 #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,10 @@ jobs:
- name: Install node deps
run: bun install
# No turbo cache: published artifacts are always built from source.
# Ensure npm >= 11.15.0 for OIDC/provenance
# npm >= 11.15.0 for OIDC/provenance. Pinned to 11: npm 12 changed CLI output
# (e.g. `npm pack --json`) that release tooling reads.
- name: Update npm
run: npm install -g npm@latest
run: npm install -g npm@^11.15.0

# Native helpers: binaries built, signed, and notarized earlier in this run
# for helpers this publish releases; the published version pinned by varlock
Expand Down
7 changes: 5 additions & 2 deletions scripts/fetch-native-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,11 @@ for (const suffix of platforms) {

const workDir = path.join(tmp, suffix);
fs.mkdirSync(workDir);
const [packed] = JSON.parse(npm(['pack', spec, '--json'], workDir));
execFileSync('tar', ['-xzf', packed.filename], { cwd: workDir });
// don't parse `npm pack --json`: npm 12 changed it from an array to an object keyed by name
npm(['pack', spec], workDir);
const tarballs = fs.readdirSync(workDir).filter((f) => f.endsWith('.tgz'));
if (tarballs.length !== 1) throw new Error(`expected one tarball from npm pack ${spec}, found: ${tarballs.join(', ') || 'none'}`);
execFileSync('tar', ['-xzf', tarballs[0]!], { cwd: workDir });

const entry = SUBDIR_CONTENTS[suffix];
const destDir = path.join(DEST, suffix);
Expand Down
Loading