Repository navigation
test: disable tool installation when loading examples - #4669
Merged
Merged
Conversation
aheritier
added
area/testing
dgageot
marked this pull request as ready for review
October 20, 2026 10:01
trungutt
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
aheritier
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable automatic tool installation only inside
TestLoadExamples, using the existingDOCKER_AGENT_AUTO_INSTALL=falseopt-out before its parallel subtests start. Example parsing and construction assertions remain unchanged; installer tests retain their existing coverage.Complements #4647, which opted out the dedicated LSP tests but not example loading. Implements the first test-specific finding from #4664. No profiling workflow or production-code changes.
Hosted results
CI run passed, including Linux, Windows, cross-compile, lint, and gate. CodeQL passed too. Raw test artifacts contain no tool-installation messages from
pkg/teamloader.Previously these example subtests took roughly 24–51 seconds each because they waited for
goplsinstallation. After this change:toolset-working-dir.yamlcoder.yamlgopher.yamlmodernize-go-tests.yamlThese are individual subtest durations, not additive CI wall-time savings; setup, other tests, and runner variation still affect whole-job timing.
Validation
task build,task test,task lintgo test -count=1 -json ./pkg/teamloaderCommit is cryptographically signed and DCO-signed.