Skip to content

PauseManager: Add class implementation. - #79

Open
cristian64 wants to merge 2 commits into
doldecomp:mainfrom
cristian64:pausemanager
Open

cristian64 wants to merge 2 commits into
doldecomp:mainfrom
cristian64:pausemanager

Conversation

@cristian64

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Report for MarioClub_us (ffc513c - e90d292)

📈 Matched code: 47.22% (+0.13%, +4208 bytes)
📈 Linked code: 42.07% (+0.14%, +4476 bytes)
📈 Matched data: 24.89% (+0.00%, +32 bytes)
📈 Linked data: 32.47% (+0.03%, +252 bytes)

✅ 11 new matches
Unit Item Bytes Before After
main/Kameda/PauseManager PauseManager::exec() +2429 0.16% 100.00%
main/Kameda/PauseManager PauseManager::PauseManager(JKRHeap*) +552 0.72% 100.00%
main/Kameda/PauseManager PauseManager::draw() +548 0.72% 100.00%
main/Kameda/PauseManager PauseManager::getPauseChoice() +328 1.20% 100.00%
main/Kameda/PauseManager PauseManager::reset() +209 1.89% 100.00%
main/Kameda/PauseManager PauseManager::wipeOut(int) +60 6.25% 100.00%
main/Kameda/PauseManager PauseManager::setTA() +33 11.11% 100.00%
main/Kameda/PauseManager .sdata2 +32 0.00% 100.00%
main/Kameda/PauseManager Result2D::getDrawFlag() +8 0.00% 100.00%
main/Kameda/PauseManager Result2D::setDrawFlag(bool) +8 0.00% 100.00%
main/Kameda/Result2D Result2D::getResultSelector() +4 50.00% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/Kameda/PauseManager .rodata +104 21.05% 97.36%

@cristian64
cristian64 force-pushed the pausemanager branch 5 times, most recently from 25c35be to 8184b9a Compare August 25, 2026 20:23
@cristian64
cristian64 force-pushed the pausemanager branch 4 times, most recently from fb963e3 to db6c252 Compare September 9, 2026 21:33
@cristian64
cristian64 force-pushed the pausemanager branch 3 times, most recently from 240f153 to 873a2c8 Compare September 17, 2026 21:06
When working on a translation unit, it is not rare that other `.cpp`
files have to be touched, even though those files have not been worked
on and therefor are not expected to have all the symbols defined yet, or
in the right order.

This change is to skip objects that have not yet been marked as
complete, as that makes fail PR checks fail in the CI.
@cristian64
cristian64 marked this pull request as ready for review September 18, 2026 20:15
@cristian64

Copy link
Copy Markdown
Contributor Author

First commit will be rebased away once #83 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant