CI: Skip symbols order check if object not marked as complete. - #83
Open
cristian64 wants to merge 1 commit into
Open
cristian64 wants to merge 1 commit into
cristian64 wants to merge 1 commit into
Conversation
When working on a translation unit, it is not rare that other `.cpp` files have to be touched, even though those files have not been worked on and therefor are not expected to have all the symbols defined yet, or in the right order. This change is to skip objects that have not yet been marked as complete, as that makes fail PR checks fail in the CI.
cristian64
marked this pull request as ready for review
September 18, 2026 20:10
Contributor
Author
|
A practical example of this issue can be seen in #79, where EDIT: Link to one failed job: https://github.com/doldecomp/mkdd/actions/runs/35274834705/job/105382791956?pr=79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on a translation unit, it is not rare that other
.cppfiles have to be touched, even though those files have not been worked on and therefor are not expected to have all the symbols defined yet, or in the right order.This change is to skip objects that have not yet been marked as complete, as that makes fail PR checks fail in the CI.