Skip to content

CI: Skip symbols order check if object not marked as complete. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristian64 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI: Skip symbols order check if object not marked as complete. #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions tools/check-changed-symbol-order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,17 @@ def source_to_unit() -> dict:
units = json.load(f).get("units", [])
out = {}
for u in units:
sp = u.get("metadata", {}).get("source_path")
if sp:
out[norm(sp)] = (u["name"], u.get("base_path", ""))
metadata = u.get("metadata", {})
if not metadata:
continue
sp = metadata.get("source_path")
if not sp:
continue
out[norm(sp)] = (
u["name"],
u.get("base_path", ""),
metadata.get("complete", False),
)
return out


Expand All @@ -58,11 +66,15 @@ def main(argv) -> int:
print(f"skip {f} (not a tracked decomp unit)")
skipped.append(f)
continue
unit, base = entry
unit, base, complete = entry
if base and not os.path.exists(os.path.join(root_dir, base)):
print(f"skip {f} ({unit}: object not built)")
skipped.append(f)
continue
if not complete:
print(f"skip {f} ({unit}: object not marked as complete)")
skipped.append(f)
continue

print(f"\n{'=' * 72}\n{f} -> {unit}\n{'=' * 72}")
rc = subprocess.run([sys.executable, VALIDATOR, "-u", unit],
Expand Down
Loading