Skip to content

feat: import GitHub review threads into the inbox with scoped follow-up (#306) - #319

Merged
douglasjarquin merged 11 commits into
mainfrom
sum/t-e06786cc4d18
Oct 19, 2026
Merged

douglasjarquin merged 11 commits into
mainfrom
sum/t-e06786cc4d18

Conversation

@douglasjarquin

@douglasjarquin douglasjarquin commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #306.

GitHub review threads become a source for the existing inbox. Triage, corrective work and resolution on GitHub stay separate.

  • Observation: an explicit pr reconcile records review threads, and any overall review decision, against the verified repository, PR and observed head. Each thread keeps its stable GitHub thread and comment IDs, author, source URL, file and line, latest reply, resolved and outdated state, and observation time. The GitHub call is a read-only GraphQL query.
  • Saved views: status, inbox (including inbox --live) and context show the saved threads without calling GitHub, and nothing runs in the background. Identical observations create no duplicate inbox item.
  • Pagination and failures: incomplete responses are recorded as incomplete. A partial result never implies that unseen threads closed, and earlier observations stay available with their freshness.
  • Actions: Address, Discuss, Draft reply, Open comment, and Address selected/all use [P1] Add structured inbox decisions with recommendations, Explain, and guarded actions #305's shared action descriptions. A bulk Address names the exact thread IDs and revisions in one bounded request.
  • Repairs: Address goes through the existing task and attempt checks, stable repair keys and delivery handling, and uses the existing in-scope and expansion rules. Sending or finishing a repair never posts a reply or resolves a thread. Draft reply produces text to review; publishing it is a separate, authorized action.
  • Revalidation: a changed PR binding or head, or a stale thread selection, is rechecked before any action. A new reply or a reopened thread becomes actionable without creating duplicate work.
  • Help and the pipeline feature map are updated. A plan doc is under docs/plans/.

Test source. Two existing assertions were made stale by the requested thread observation and were updated as the user authorized:

  • go/internal/prcmd/readonly_test.go: the retry-boundary expected list now includes observeReviewThreads.
  • go/internal/cli/quiet_coordination_replay_test.go: the remote-call audit allow-list now includes api graphql. The replay reaches only the read-only thread query.

The pinned help output was regenerated. No new tests were written, so the issue's focused-coverage item is not done in test code, and the feature map says the coverage does not exist.

Verification

https://claude.ai/code/session_01LmjWPRZjxcGH3kQmkpRToB

Pipeline

Generated by sum

Stage Status Result
Intent ✅ Approved brief recorded
Rebase ✅ Up to date with main (main at 7f3b46d, observed 2026-10-19T01:42Z)
Review ✅ Passed after 1 remediation pass
Test ✅ Passed; the run certifies no candidate
Document ✅ Passed
Lint ✅ Passed (mise run lint)
Push ✅ Pushed dea8598 to origin/sum/t-e06786cc4d18
PR ✅ Open: #319
CI ➖ No checks reported for this PR (as of 2026-10-18T05:30Z)

Review summary

Review remediation log

Pass 1

  • Limitation: This pass recorded no structured notes.

@douglasjarquin
douglasjarquin marked this pull request as ready for review October 18, 2026 05:30
@douglasjarquin douglasjarquin changed the title Factory issue douglasjarquin/sum#306 feat: import GitHub review threads into the inbox with scoped follow-up (#306) Oct 18, 2026
@douglasjarquin

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts on this branch.

Copilot AI commented Oct 18, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts on this branch.

I couldn't proceed: ./bin/sumctl init failed because the staged native binary is missing (run mise run setup or stage a release). Per the repository procedure, I stopped rather than continuing without a validated role.

@douglasjarquin
douglasjarquin merged commit 44214f0 into main Oct 19, 2026
3 checks passed
@douglasjarquin
douglasjarquin deleted the sum/t-e06786cc4d18 branch October 19, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] Import GitHub review threads into the inbox with scoped follow-up actions

2 participants