Repository navigation
Reader 0.4: private comparison, trustworthy evidence and installed-package delivery - #288
Conversation
andy-zen-dev
left a comment
There was a problem hiding this comment.
Exact-head technical review: 8f4194fdf75be9b1f5de276b6400feff508cd9f9 on master 5c03ee428df6cc36ebdeff2443d35ac9f7e72dca.
Inspected the 14-file patch, strict JSON/Decimal validator, CLI dispatch, source-unit safeguards, installed-wheel smoke and privacy/error/export boundaries. No new blocking code finding in this review. All 23 applicable GitHub Actions runs are completed/successful on the exact head (Reader installed wheel, Pages build, pinned morphology and frozen/provenance checks). There are no unresolved inline threads. This is not FantLab parity: M2 remains 0/5. Pages deployment is skipped; LIVE_VERIFIED is not claimed.
This is a COMMENT review, not an invented independent approval of my own PR. A later permitted merge still requires native repository gates and fresh SHA verification. The previous safety denial on the identical merge operation has not been bypassed.
Product outcome
Reader 0.4.0a1 delivers a complete private
manuscript -> actual analyzer -> compare -> HTML/JSON/CSVpath and trustworthy frozen-work display. Accumulated unpublished work is now repository code, not a second prototype runtime.Closes #279. Closes #286. Partially addresses #283 (touch targets only).
Delivered
scriptorium compare: all 29 canonical metric rows, exact JSON decimal differences (right minus left), percentage-point deltas, explicit units/status and source/profile/dictionary identities.Final exact-head verification
Head:
8f4194fdf75be9b1f5de276b6400feff508cd9f9Base:
5c03ee428df6cc36ebdeff2443d35ac9f7e72dcaScope: 3 commits, 14 files, +1421/-79 lines. Existing
scrip-compare-003-local-clireused; no new branch.build_local_analysis(), not analyzer stubs.scriptorium_reader-0.4.0a1-py3-none-any.whl, 370400 bytes, SHA-25635aaa7644bf1a0fb09f51fde441c587eebd6693e5783fca5ede756d63a2c04f5(build evidence, not a registry release).12407216390, verified SHA-256ce6c1b062c10599d8a04e0d9e4c69e00764bf3a6fd4c5c3e97164f87c5e54931. Checked all 30 internal links/fragments across seven HTML pages (homepage + six routes), ten shared metrics, twenty CSV measurements, seven charts, exact JSON/CSV values/units/source hashes/deltas and touch-target CSS: PASS.The initial CI run passed 809 tests but exposed a legacy hardcoded 0.2.0a1 smoke expectation. Fixed by requiring project, installed metadata and exact CLI version agreement, with
-Iisolation; no existing tests or publication protections were weakened.Reconciled backlog and boundaries
Earlier #278 was freshly reviewed and merged as the base above; native GitHub closed #277. Recovered distinct outbox debts as #287 (POS benchmark join), #289 (EPUB ingestion) and #290 (batch analysis) after open/closed deduplication. The retained private comparator archive is marked RECONCILED_TO_GITHUB; no private storage IDs or manuscript text were published.
Browser #280, readiness #281, AOT #282, remaining accessibility #283, licensing #284 and deployment #285 remain open. EPUB/batch prototype bytes were not recovered here and are not represented as implemented. Current scientific source artifacts and tolerance rules are unchanged; M2 remains 0/5.
Local browser HTTP navigation returned
ERR_BLOCKED_BY_ADMINISTRATOR. VISUAL_NOT_VERIFIED; structural checks do not establish visual/live acceptance. The Pages activation interlock is unchanged. No scheduler, access/administration or visibility changes.PR_CREATED / BUILT / CI_PASS; NOT_MERGED / NOT_DEPLOYED / NOT_LIVE_VERIFIED. Newly authored implementation requires later fresh exact-head acceptance. It is not self-approved or merged in its authoring session.