Repository navigation
Conversation
The AFU page links to the file format specification, the changelog, and two figures in afu/. The generator copied only the specification, only when afu/ did not have it yet, and only from <release>/annotation-file-utilities/ inside the zip. The annotation-tools zips have annotation-file-utilities/ at the top, so nothing was copied: the specification on the site is from an old release, and afu/changelog.html and afu/figures/*.svg are not on the site at all (both return 404). The extraction also swallowed a ZipException. Copy the specification (HTML and PDF), changelog.html and figures/ from the latest zip on every run, whether annotation-file-utilities/ is at the top of the zip or inside a release directory, as in the zips built by the Checker Framework. A document that the zip lacks keeps its earlier copy. Read errors now fail the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
afu/annotation-file-utilities.htmllinks toannotation-file-format.{html,pdf},changelog.html,figures/tool-relations.svgandfigures/scene-lib-type-hierarchy.svg.getAFUcopied only the format specification, only whenafu/lacked it, and only from<release>/annotation-file-utilities/inside the zip. Theannotation-tools-*.zipassets haveannotation-file-utilities/at the top level (checked for 3.49.5-eisop1), so nothing is ever copied. On the live site:afu/annotation-file-format.*: present, but left over from an older generator and never refreshed.The extraction also swallowed
ZipException.Fix. A new
extractAfuDocscopies the specification (HTML and PDF),changelog.htmlandfigures/*.{svg,png}out of the latest AFU zip on every run, matching entries whetherannotation-file-utilities/is at the top of the zip or one directory down (the layout of theannotation-file-utilities-VERSION.zipbuilt by the Checker Framework). Documents the zip lacks (for examplechangelog.htmlin the new zips) keep their earlier copy. Read errors now fail the run instead of being printed and ignored.This touches a part of
getAFUthat #112 does not change; a test merge withafu-in-cf-releaseis clean.Testing.
mvn package; a generator run with--only-latestnow extracts the five documents fromannotation-tools-3.49.5-eisop1.zipintoafu/. A hand-made zip with the newer layout (annotation-file-utilities-X/annotation-file-utilities/...) extracts the specification and figures, ignores other files (including atests/.../changelog.htmland a nestedfigures/sub/entry), and keeps an existingchangelog.html.Note: the AFU zip built by the Checker Framework (
annotationFileUtilitiesZipin the integrate-afu work) includes*.pngbut notfigures/*.svg, so the figures would come only from the older zips until that zip includes them.