Repository navigation
Fix/gren dockerfile non root user - #103
Closed
bcurcin-godaddy wants to merge 4 commits into
Closed
bcurcin-godaddy wants to merge 4 commits into
bcurcin-godaddy wants to merge 4 commits into
Conversation
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
🤖 GitHub commentsJust comment with:
|
Author
|
Closing: retargeting this change to gdcorp-wordpress/ecs-logging-php:main (cannot change base repo on an existing PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds USER node to the gren release-tooling Dockerfile, making the existing unprivileged account the image’s default runtime user. Package installation remains before this instruction and continues to run as root.
The Makefile’s existing -u$(CURRENT_UID):$ (CURRENT_GID) override remains unchanged, preserving host-user ownership of generated files in the mounted checkout. No entrypoint or release-workflow changes are required.
Validation:
Complete builds of both the original and modified Dockerfiles fail at the unchanged APT step because Debian Stretch repository URLs return HTTP 404. Focused runtime checks omitted that failing step; the base-image upgrade remains separate work.
After merge, rescanning should confirm closure of both alerts, including the entrypoint-specific rule that was not separately tested locally.
Created by GPT-6-Astra.