Repository navigation
Check group access before saving feedback and grades - #163
Merged
adrian-sarmas merged 1 commit intoOct 11, 2026
Merged
adrian-sarmas merged 1 commit into
adrian-sarmas merged 1 commit into
Conversation
PM84
force-pushed
the
MBS-11230_Check_Group_Access_On_Feedback
branch
from
October 9, 2026 20:32
d5b4f26 to
f845865
Compare
adrian-sarmas
merged commit Oct 11, 2026
b439a2f
into
elearningsoftware:master
87 of 100 checks passed
adrian-sarmas
added a commit
that referenced
this pull request
Oct 11, 2026
Follow-up to #163. In separate groups mode, report.php showed all entries to a grader who is in no group and cannot access all groups, and journal_pluginfile served entry and feedback files of any student to any grader. Both now respect group visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was identified during a penetration test. The report form, the AJAX handler and the save_feedback web service wrote feedback and grades to any entry of the journal, ignoring separate groups; this change skips or rejects entries whose owner is not visible to the grader (groups_user_groups_visible) and adds a unit test.