Skip to content

ewoks convert: record the ewoks version and engine in the workflow requirements - #361

Merged
woutdenolf merged 1 commit into
mainfrom
requirements_ewoks_version
Nov 3, 2026
Merged

woutdenolf merged 1 commit into
mainfrom
requirements_ewoks_version

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

PR summary

Chain of PRs for #341, install the environment of a workflow with only a package manager. Merge in order: #361 → #362 → #363 → #348 → #364

AI Disclosure

  • AI tool Claude used to create the code, tests and docs.

🤖 Generated with Claude Code

…w requirements

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoks/_engines.py 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@woutdenolf
woutdenolf requested a review from a team October 24, 2026 13:28
@loichuder

Copy link
Copy Markdown
Member

What would happen if there is a mismatch between the version of ewoks stored in requirements and the one used to run ewoks install?

@woutdenolf

woutdenolf commented Nov 3, 2026 •

Copy link
Copy Markdown
Member Author

What would happen if there is a mismatch between the version of ewoks stored in requirements and the one used to run ewoks install?

Nothing. Like the python and system info it is informational. However unlike the python and system info, it is used by the bootstrap script to create the bootstrap environment.

@woutdenolf
woutdenolf merged commit 7f58ae1 into main Nov 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants