[flowcool]

Behavior

Activity review now supports explicit bounded reconciliation profiles. off remains the default. Matching uses complete one-to-one candidate graphs, local calendar dates, exact gross limits and source-derived fees. Unique legacy references can migrate under the configured account mapping.

fresh source + destination evidence
  -> manual yes or bounded profile authority
  -> one shared PUT budget
  -> durable journal + exact readback

Schema 3 provides one compact decision file and a private bound state file. Pair rejection affects only its source-target association. Historical maintenance keeps separate operation authority and exact selected-subset replay. Group diagnosis never authorizes aggregate corrections.

Release impact

Major. The review-file and new journal formats change recovery compatibility. Back up the operator file, .state.yaml companion and journal together. Schemas 1 and 2 migrate with cleared consent. Old unresolved journal entries remain readable. Keep a compatible reader until pending requests settle. Software rollback does not reverse financial writes.

Profiles are opt-in. Stable publication and production require separate GO. Exact-image empty/golden lab qualification remains pending. Shared import/index helpers changed: downstream propagation needs separate review; DEGIRO remains pinned.

Verification

• bash scripts/check.sh: PASS: Ruff, strict mypy (15 modules), and all 2,967 offline tests.
• Synthetic regression cases cover thresholds, DST, numerical residue, migration, state generations, rejection, journal recovery, no resend, one-write budgeting, grouped outcomes and maintenance selections.
• A same-group dividend rejection test failed before the correction and passes after it. A journal-recovery result-count test also failed before its correction and passes after it.
• openspec validate --all --strict: PASS after archive: 6 specifications, 0 failures. All eleven tasks are complete in openspec/changes/archive/2026-10-28-profiled-activity-reconciliation/.
• git diff --check: PASS.

AI assistance

Codex implemented the approved OpenSpec tasks. The author checked the complete diff, preservation and account boundaries, exact decimal evidence, offline tests and strict typing. Planning received two earlier Claude reviews.

Pullfrog review

Pending review of the pushed implementation head. The operator requested a pause after this push to add CodeRabbit review. This PR remains open. Merge and release preparation await resumption. The repository Pullfrog and required-CI gates still apply before merge.

Review evidence: pending.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: flowcool/ghostfolio-ibkr-sync
• Branch: spec/profiled-activity-reconciliation
• File: .coderabbit.yaml
• Commit: 2041e50
• Layers: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3ddd032d-5891-4445-8c83-dfc6b3a428ad

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pullfrog]

ℹ️ No critical issues — one minor suggestion inline.

Reviewed changes — the profiled reconciliation implementation (runtime, maintenance CLI, specs, ADRs and docs). I read the code paths end to end and skimmed the tests; I did not run the test suite (the review runner has no .venv).

• Reconciliation rules — new activity_reconciliation.py with local-date eligibility, exact Decimal gross limits, residue evidence and group diagnosis.
• Compact review (schema 3) — operator view plus private .state.yaml with generation recovery; schemas 1/2 migrate with consent cleared; journal v2 records authority and eligibility.
• Shared PUT budget — profile-authorized and manual corrections go through selected_proposals, the same QUALIFIED_EXECUTION limit, fresh re-qualification before each dispatch and the existing journal/readback path. simulated now also covers the forced TZ preview, and every write guard still sits behind it.
• Pair rejection — rejected source/target pairs are excluded from trade and dividend proximity matching only for that pair.
• Maintenance CLI — schema 3 historical staging, rebuild-review, state hash bound in the manifest.

ℹ️ Profiles add an automatic update path for existing activities

Under conservative/balanced/permissive, the connector now rewrites an existing Ghostfolio activity without a per-item yes. AGENTS.md, ADR 0003/0009 and the archived OpenSpec change all record this as intended and bounded (opt-in, one correction per cycle, journal plus readback), so I treat it as approved scope rather than a defect. It is the one place where this PR departs from the "never update automatically" default, so the operator GO for the exact-image lab runs should explicitly cover it.

ℹ️ Downstream propagation

index_existing_activities now appends the activity id to manual_buys/manual_sells/dividend_dates entries, and _dividend_date_matches slices it off again. The PR body already flags DEGIRO propagation. The index_existing_activities docstring in ghostfolio.py (around lines 233–236) still describes the old two- and four-element shapes.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using claude-sonnet-5-5 ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes — the single commit since the prior Pullfrog review (2041e50). It touches tests, one docstring and removes dead code; no runtime behavior changes. I did not run the test suite (the review runner has no .venv).

• Removed dead financial_eligible — the unused function and its dividend_quantity_proven flag are gone from activity_reconciliation.py, so the quantity rule lives only in automatic_pairs.
• Tests exercise the production rule — the quantity, denomination (GBp/GBP/EUR) and sub-precision gross boundary tests now call automatic_pairs, which authorizes writes.
• Docstring updated — index_existing_activities documents the activity id element in manual_sells, manual_buys and dividend_dates entries.

The prior inline thread on financial_eligible is addressed and already resolved.

  ^{｜ Fix it ➔ ｜ View workflow run ｜ Using claude-sonnet-5-5 ｜ 𝕏}