Compile the signature file fslex generates for lex.fsl - #3449
Merged
Conversation
lex.fsi was the one generated signature left out of the build. lex.fsl's header defines a nested module, and fslex copied that module declaration into the signature while dropping its body, producing a file that would not compile. FsLexYacc 11.4.1 fixes that (fsprojects/FsLexYacc#240), so bump the pin and take the Compile item out of comments. Compiling it exposes the missing .fsi in the package's CallFsLex Outputs, the fslex side of the bug CallFsYacc is already overridden for. Every generated .fsi is a Compile item, so deleting one on its own left the build asking for a source file that no rebuild would put back. Override CallFsLex the same way. The CallFsYacc override stays: 11.4.1 ships none of the fixes it carries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lex.fsi was the one generated signature left out of the build. lex.fsl's header defines a nested module, and fslex copied that module declaration into the signature while dropping its body, producing a file that would not compile. FsLexYacc 11.4.1 fixes that (fsprojects/FsLexYacc#240), so bump the pin and take the Compile item out of comments.
Compiling it exposes the missing .fsi in the package's CallFsLex Outputs, the fslex side of the bug CallFsYacc is already overridden for. Every generated .fsi is a Compile item, so deleting one on its own left the build asking for a source file that no rebuild would put back. Override CallFsLex the same way.
The CallFsYacc override stays: 11.4.1 ships none of the fixes it carries.