Skip to content

Compile the signature file fslex generates for lex.fsl #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 2 commits into from
Aug 28, 2026
+32 −14
Merged

Compile the signature file fslex generates for lex.fsl #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d09258
Compile the signature file fslex generates for lex.fsl
nojaf Aug 28, 2026
8202458
Update Fantomas to alpha 25
nojaf Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"rollForward": false
},
"fantomas": {
"version": "8.0.0-alpha-022",
"version": "8.0.0-alpha-025",
"commands": [
"fantomas"
],
Expand Down
24 changes: 21 additions & 3 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
</ItemGroup>

<!--
Overrides the CallFsYacc target from the FsLexYacc package. This file is imported after the
package's targets, so this definition is the one that runs.
Overrides the CallFsLex and CallFsYacc targets from the FsLexYacc package. This file is
imported after the package's targets, so these definitions are the ones that run.

fsyacc prints every shift/reduce and reduce/reduce conflict it finds, unconditionally: there
is no quiet or nowarn flag. For pars.fsy that is over 1400 lines of conflict reports on every
Expand All @@ -27,8 +27,26 @@
2. The FileWrites ItemGroup is a copy-paste of the one in CallFsLex and registers the fslex
output paths, so the generated parsers are never removed by dotnet clean.

Once those are fixed and released, this override can go away.
Bug 1 applies to CallFsLex too, and it is the reason that target is overridden here as well:
every generated .fsi is a Compile item, so deleting one on its own leaves the build unable to
find a source file it was told to compile, and no rebuild puts it back. CallFsLex needs the
Outputs fix alone; its FileWrites group already names the fslex paths. fslex is quiet, so
that Exec keeps the default output importance.

Once those are fixed and released, these overrides can go away.
-->
<Target Name="CallFsLex"
Inputs="@(FsLex)"
Outputs="@(FsLex->'$(FsLexOutputFolder)%(Filename).fs');@(FsLex->'$(FsLexOutputFolder)%(Filename).fsi')"
Condition="'@(FsLex)'!=''"
BeforeTargets="CoreCompile">
<MakeDir Directories="$(FsLexOutputFolder)" />
<Exec Command="$(FsLexYaccToolRunner)&quot;$(FsLexToolPath)\$(FsLexToolExe)&quot; -o &quot;$(FsLexOutputFolder)%(FsLex.Filename).fs&quot; %(FsLex.OtherFlags) %(FsLex.Identity)" />
<ItemGroup>
<FileWrites Include="$(FsLexOutputFolder)%(FsLex.Filename).fs;$(FsLexOutputFolder)%(FsLex.Filename).fsi" />
</ItemGroup>
</Target>

<Target Name="CallFsYacc"
Inputs="@(FsYacc)"
Outputs="@(FsYacc->'$(FsYaccOutputFolder)%(Filename).fs');@(FsYacc->'$(FsYaccOutputFolder)%(Filename).fsi')"
Expand Down
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="10.0.6" />
<PackageVersion Include="System.Memory" Version="4.6.3" />
<PackageVersion Include="System.Runtime" Version="4.3.1" />
<PackageVersion Include="FsLexYacc" Version="11.3.0" />
<PackageVersion Include="FsLexYacc" Version="11.4.1" />

<!-- Hosts the vendored FSharpEmbedResourceText MSBuild task, see Fantomas.FCS.BuildTasks. -->
<PackageVersion Include="Microsoft.Build.Framework" Version="18.0.2" />
Expand Down
6 changes: 3 additions & 3 deletions src/Fantomas.FCS/Fantomas.FCS.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,9 @@
<Compile Include="$(FsYaccOutputFolder)pplex.fs">
<Link>SyntaxTree\FsLexOutput\pplex.fs</Link>
</Compile>
<!-- <Compile Include="$(FsYaccOutputFolder)\lex.fsi">-->
<!-- <Link>SyntaxTree\FsLexOutput\lex.fsi</Link>-->
<!-- </Compile>-->
<Compile Include="$(FsYaccOutputFolder)\lex.fsi">
<Link>SyntaxTree\FsLexOutput\lex.fsi</Link>
</Compile>
<Compile Include="$(FsYaccOutputFolder)\lex.fs">
<Link>SyntaxTree\FsLexOutput\lex.fs</Link>
</Compile>
Expand Down
12 changes: 6 additions & 6 deletions src/Fantomas.FCS/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
},
"FsLexYacc": {
"type": "Direct",
"requested": "[11.3.0, )",
"resolved": "11.3.0",
"contentHash": "v0Q3/c0tizN8vRZ72Tdo+OKU767Yjul0wRJgG1/W15H4tK/9qHne/mylw/gTEIC8FV2zgiDlAudhQpdZXYG3IA==",
"requested": "[11.4.1, )",
"resolved": "11.4.1",
"contentHash": "t77MbPw80ndxR0GGkoFByCl27/oWW5jtLN7S4aYQ21IfoBnskXNdtOlxt7cJw/F9aD2dd8kqCrRbpMuE0cDyaQ==",
"dependencies": {
"FSharp.Core": "4.6.2",
"FsLexYacc.Runtime": "11.3.0"
"FsLexYacc.Runtime": "11.4.1"
}
},
"G-Research.FSharp.Analyzers": {
Expand Down Expand Up @@ -94,8 +94,8 @@
},
"FsLexYacc.Runtime": {
"type": "Transitive",
"resolved": "11.3.0",
"contentHash": "36b+4G+85WXU3kmbtq9hFSMGCLkn1nLzJoPgNaLUusnjXrC5ndAyS+hl13H6frpLCS3DB1wAmx/1SGYDe0avMw==",
"resolved": "11.4.1",
"contentHash": "BNLDgkJMztlyUgVV2SuECN5nPZK1C70g06r/dMKmyG7BbbLnQjTuCjAjrde0A5PLEKuVobIQAhuS7ljpoDX9aA==",
"dependencies": {
"FSharp.Core": "4.6.2"
}
Expand Down