Repository navigation
feat(settings): Align cmd+k, page titles and copy with settings-v3 - #129658
Open
sentry-junior[bot] wants to merge 6 commits into
Open
sentry-junior[bot] wants to merge 6 commits into
sentry-junior[bot] wants to merge 6 commits into
Conversation
With settings-v3 on, cmd+k still showed the old 'General Settings' and 'Account Details' labels and listed account pages next to org pages. Browser tab titles also did not match the new 'General' headers. Cmd+K now uses the v3 navigation config and groups account pages under Account Settings. Tab titles, the replays settings link, the nav LLM context hint and a JSDoc follow the v3 scopes. Without the flag nothing changes. Co-Authored-By: Priscila Andre de Oliveira <29228205+priscilawebdev@users.noreply.github.com>
github-actions
Bot
added
the
Scope: Frontend
Project Settings > General already had a gear icon, but the org and account General entries had none. Under settings-v3 all three now match. Co-Authored-By: Priscila Andre de Oliveira <29228205+priscilawebdev@users.noreply.github.com>
- Title the general pages' browser tabs "Org Settings", "Account Settings" and "Project Settings" with settings-v3, so the account tab is no longer a bare "General". - Share the settings-v3 General icons between the global cmd+k actions and the settings field sections, so the account General page no longer shows two different icons. - Prefix field section titles with their scope only when the title is used by more than one scope, derived from the navigation config instead of a hard-coded path list. - Move getSettingsScopeTitle and SettingsScope out of the useSettingsScope hook module into settingsScope.ts. - Reuse the existing org API mocks in the cmd+k spec and add a spec for the field sections.
Add getSettingsScopeIcon next to getSettingsScopeTitle so each settings scope has one title and one icon. The settings navigation rail and the cmd+k Org, Project and Account settings groups now use it, so the org scope shows the same building icon in both instead of a gear in cmd+k. Also use getSettingsScopeTitle for the remaining "Project Settings" labels in the settings-v3 surfaces: the project General tab title, the organization dropdown's project section and tour, and the cmd+k group.
The command palette kept two path-to-icon maps for settings pages, one for the settings pages list and one for the settings field sections, plus a settings-v3 override shared between them because the two maps disagreed. Give NavigationItem an optional icon and set it next to the path and title in the org and account navigation config. Both command palette lists already read from that config, so they now use item.icon and the three maps are gone. The settings-v3 case for the account General page becomes a plain ternary in the config, like its title. Pages now show the same icon in both lists, so a few pages gain an icon in one of them (e.g. Security and Email Addresses in the pages list).
The org, project and account General pages are the home page of their settings scope, so give them that scope's icon from the settings navigation rail (building, project and user) instead of a gear. The icon no longer depends on settings-v3.
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 736520a. Configure here.
priscilawebdev
marked this pull request as ready for review
November 3, 2026 12:25
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
