Skip to content

ref(consumer): Remove the legacy rdkafka consumer path #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvthanh03 merged 1 commit into from
Oct 22, 2026
Merged

ref(consumer): Remove the legacy rdkafka consumer path #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 8 additions & 56 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,8 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}

rebalance-integration-test:
name: Rebalance integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Rebalance integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -312,14 +306,8 @@ jobs:
make test-rebalance

worker-processing-integration-test:
name: Worker processing integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Worker processing integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -356,14 +344,8 @@ jobs:
make test-worker-processing

upkeep-retry-integration-test:
name: Upkeep retry integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Upkeep retry integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -400,14 +382,8 @@ jobs:
make test-upkeep-retry

upkeep-expiry-integration-test:
name: Upkeep expiry integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Upkeep expiry integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -444,14 +420,8 @@ jobs:
make test-upkeep-expiry

upkeep-delay-integration-test:
name: Upkeep delay integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Upkeep delay integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -488,14 +458,8 @@ jobs:
make test-upkeep-delay

failed-tasks-integration-test:
name: Failed tasks integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Failed tasks integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -532,14 +496,8 @@ jobs:
make test-failed-tasks

multi-topic-integration-test:
name: Multi-topic integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Multi-topic integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down Expand Up @@ -576,14 +534,8 @@ jobs:
make test-multi-topic

push-postgres-integration-test:
name: Push mode postgres integration test${{ matrix.consumer_backend == 'arroyo' && ' (arroyo)' || '' }}
name: Push mode postgres integration test
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
consumer_backend: [rdkafka, arroyo]
env:
TASKBROKER_USE_ARROYO_CONSUMER: ${{ matrix.consumer_backend == 'arroyo' }}

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
Expand Down
7 changes: 0 additions & 7 deletions src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@ pub struct Config {
/// The path to the runtime config file
pub runtime_config_path: Option<String>,

/// Consume with Arroyo's async Kafka consumer instead of rdkafka's stream consumer.
pub use_arroyo_consumer: bool,

/// The frequency at which upkeep tasks
/// (discarding, retrying activations, etc.) are executed.
pub upkeep_task_interval_ms: u64,
Expand Down Expand Up @@ -300,7 +297,6 @@ impl Default for Config {
kafka_send_timeout_ms: 500,
store: StoreConfig::default(),
runtime_config_path: None,
use_arroyo_consumer: false,
upkeep_task_interval_ms: 1000,
upkeep_unhealthy_interval_ms: 5000,
health_check_killswitched: false,
Expand Down Expand Up @@ -1046,7 +1042,6 @@ mod tests {
assert_eq!(config.store.sqlite.vacuum_page_count, None);
assert_eq!(config.canary_tasks, 0);
assert!(config.worker_map.is_empty());
assert!(!config.use_arroyo_consumer);
}

#[test]
Expand Down Expand Up @@ -1241,7 +1236,6 @@ mod tests {
jail.set_env("TASKBROKER_DATABASE_ADAPTER", "postgres");
jail.set_env("TASKBROKER_MAX_PROCESSING_ATTEMPTS", "5");
jail.set_env("TASKBROKER_CANARY_TASKS", "2");
jail.set_env("TASKBROKER_USE_ARROYO_CONSUMER", "true");

let args = Args {
run: Run::Broker,
Expand All @@ -1252,7 +1246,6 @@ mod tests {
assert_eq!(config.store.adapter, DatabaseAdapter::Postgres);
assert_eq!(config.store.max_processing_attempts, 5);
assert_eq!(config.canary_tasks, 2);
assert!(config.use_arroyo_consumer);

Ok(())
});
Expand Down
Loading
Loading