Repository navigation
fix(mcp): Defer find_dropped_events and lock the default tool list - #1700
Merged
Merged
Conversation
Remove find_dropped_events from the default direct tools/list surface. It stays reachable through search_sentry_tools and execute_sentry_tool. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add the no-expand-top-level-tools rule, which fails when TOP_LEVEL_TOOL_NAMES differs from the allowed list. Many harnesses still load every listed tool into the context window, so additions need an explicit rule update in the same PR. Restricted until tool search is standard in every mainstream harness, likely by 2027. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
dcramer
enabled auto-merge (squash)
October 28, 2026 17:13
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1410 added
find_dropped_eventstoTOP_LEVEL_TOOL_NAMES, which put it in the defaulttools/listpayload. That direct surface is reserved for core tools, so this moves it back to the catalog. Agents can still discover it throughsearch_sentry_toolsand call it throughexecute_sentry_tool.Generated definitions and plugin agent
allowedToolslists were regenerated to match.To keep this from happening again, a new ast-grep rule,
no-expand-top-level-tools, fails lint whenTOP_LEVEL_TOOL_NAMESinpackages/mcp-core/src/tools/surfaces.tsdiffers from the allowed list. Many harnesses still load every listed tool into the context window up front, so each addition is noise in every session. If the list really needs to grow, the PR has to update the allowed list in the rule too, so the change gets reviewed on purpose. A comment on the list says it stays locked until tool search is standard in every mainstream harness, which likely happens by 2027.Refs #1410 (comment)
via David Cramer.
--
View Junior Session [Sentry]