Repository navigation
perf(cli): Skip adjacent-event lookups on project event details - #1712
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Bump @sentry/api to 0.423.0, which defaults `collapse=adjacentEvents` on both getOrganizationIssueEvent and getProjectEvent. CLI getEvent() now sends it on the project event-details endpoint too (supported since getsentry/sentry#129123), and getLatestEvent() drops the explicit param it added in #1705 in favor of the SDK default. Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps
@sentry/apifrom 0.420.0 to 0.423.0. In 0.423.0,getOrganizationIssueEventandgetProjectEventboth sendcollapse=adjacentEventsby default (getsentry/sentry-api-schema#112 and #113). With it, Sentry skips the next/previous-event lookups. Nothing in the CLI readsnextEventIDorpreviousEventID.Requests that change:
getEvent()→projects/{org}/{project}/events/{event_id}/. This is the explicit event-ID path insentry event view. perf(api): Skip adjacent-event lookups on event details #1705 skipped it because the project endpoint didn't supportcollapseyet. perf(issues): Support collapse on project event details sentry#129123 added that support. Until it deploys, Sentry ignores the unknown value.getLatestEvent()keeps sending the param, but through the SDK default now. The explicitcollapsequery perf(api): Skip adjacent-event lookups on event details #1705 added there is gone.Tests assert both requests still carry
collapse=adjacentEvents, so a future SDK regression would show up. A tier test also confirms that project event URLs with the param stayvolatile.Behavior notes
sentry event view <org>/<project> <event-id> --jsonwill returnnextEventID/previousEventIDas null. Issue latest-event lookups already behave this way after perf(api): Skip adjacent-event lookups on event details #1705.@sentry/apimigration in docs(openspec): Propose a shared Sentry API layer for the CLI and MCP #1669 isn't touched.via BYK.
--
View Junior Session in Sentry