Repository navigation
ref(mcp): Move issue and event reads onto @sentry/api - #1713
Merged
Merged
Conversation
getEventForIssue, listEventsForIssue, and listEventAttachments now call @sentry/api operations through the existing sdkClient bridge, which keeps the MCP's auth, region routing, retries, ApiError mapping, and apiPath checks. getEventAttachment reuses listEventAttachments for its metadata lookup; the binary download stays on request(). @sentry/api sends collapse=adjacentEvents by default on getOrganizationIssueEvent (since 0.421.0), so the hand-added query parameter is gone. The pnpm catalog moves to 0.423.0. listEventsForIssue no longer sends sort. Sentry's issue events endpoint ignores it and always returns the newest events first. Co-Authored-By: BYK <burak.kaya@sentry.io>
listIssues, getIssue, getIssueTagValues, getIssueExternalLinks, listIssueIntegrations, and getAutofixState now call @sentry/api operations through the sdkClient bridge. The two link lists share a collectAllPages walker with the path-based listIssueLinkPages, which the Sentry App installation and component lists still use. listIssues keeps sending an empty query when none is given, because Sentry applies is:unresolved only when the parameter is missing. Issue writes stay on requestJSON: the bridge only forwards GETs until the MCP transport injection lands. Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Oct 29, 2026
sentry-junior Bot
added a commit
that referenced
this pull request
Oct 29, 2026
Co-Authored-By: BYK <burak.kaya@sentry.io>
sentry-junior Bot
added a commit
that referenced
this pull request
Oct 29, 2026
@sentry/api 0.423.0 (bumped in #1713) defaults `collapse=adjacentEvents` on getOrganizationIssueEvent and getProjectEvent. CLI getEvent() now sends it on the project event-details endpoint too (supported since getsentry/sentry#129123), and getLatestEvent() drops the explicit param it added in #1705 in favor of the SDK default. Tests assert both requests still carry the param. Co-Authored-By: BYK <burak.kaya@sentry.io>
BYK
added a commit
that referenced
this pull request
Oct 29, 2026
`@sentry/api` 0.423.0, which #1713 bumped on main, defaults `collapse=adjacentEvents` on `getOrganizationIssueEvent` and `getProjectEvent` (getsentry/sentry-api-schema#112 and #113). With it, Sentry skips the next/previous-event lookups. Nothing in the CLI reads `nextEventID` or `previousEventID`. Requests that change: - CLI `getEvent()` → `projects/{org}/{project}/events/{event_id}/`. This is the explicit event-ID path in `sentry event view`, and it now sends the param through the SDK default. #1705 skipped it because the project endpoint didn't support `collapse` yet. getsentry/sentry#129123 added that support. Until it deploys, Sentry ignores the unknown value. - CLI `getLatestEvent()` keeps sending the param, but through the SDK default now. The explicit `collapse` query #1705 added there is gone, along with its URL assertion, since that would only test the SDK default. A tier test confirms that project event URLs with the param stay `volatile`. ### Behavior notes - Once getsentry/sentry#129123 deploys, `sentry event view <org>/<project> <event-id> --json` will return `nextEventID`/`previousEventID` as null. Issue latest-event lookups already behave this way after #1705. - Response-cache keys for project event URLs change, so existing entries miss once and then fill again. <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent%3Aea5efd697aa911af7986f685a5952441 --> -- [View Junior Session in Sentry](https://sentry.sentry.io/explore/conversations/agent%3Aea5efd697aa911af7986f685a5952441/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: BYK <burak.kaya@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8.2 of the
unify-sentry-api-layerchange (#1669): the MCP's issue and event reads inSentryApiServicenow call@sentry/apioperations instead of buildingrequestJSON(apiPath...)URLs by hand.The calls go through the existing
sdkClient()bridge, the same one the organization, team, and project lists use. The SDK only builds the path and query. The MCP still owns auth, host and region routing, retries, theApiErrormapping (HTTP status kept), and Zod parsing. The bridge also rejects any URL that doesn't match theapiPathresult, so path-traversal protection is unchanged. When 6.1 lands, that bridge is the one place to swap in the injected fetch. Tool output and snapshots don't change.Events
getEventForIssue→getOrganizationIssueEvent. Since 0.421.0,@sentry/apisendscollapse=adjacentEventsby default (feat(client): Skip adjacent-event lookups by default in getOrganizationIssueEvent sentry-api-schema#112, server side perf(issues): Add collapse=adjacentEvents to group event details sentry#129094), so the hand-added?collapse=adjacentEventsfrom perf(api): Skip adjacent-event lookups on event details #1705 is gone. The existing request test still checks the parameter forlatest,oldest,recommended, and a hex ID. The generatedevent_idtype lists only the three aliases, so a hex ID needs a narrow cast.listEventsForIssue→listOrganizationIssueEvents. It no longer sendssort. The generated operation has no such parameter, andGroupEventsEndpointignores it: results always come back-timestampfirst.search_issue_eventsstill uses its sort for the Discover link. Tests now check that link instead of the ignored query parameter.listEventAttachments→listProjectEventAttachments.getEventAttachmentreuses it for the metadata lookup.collapseto keep.getProjectEventdefaults it anyway as of 0.423.0 (feat(sdk): Default collapse=adjacentEvents on getProjectEvent sentry-api-schema#113).Issues
listIssues,getIssue,getIssueTagValues,getIssueExternalLinks,listIssueIntegrations, andgetAutofixStatenow use their operations.listIssuesstill sendsquery=when it's empty, because Sentry appliesis:unresolvedonly when the parameter is missing. A new test covers this. The two link lists share a smallcollectAllPageswalker withlistIssueLinkPages, which the Sentry App lists still use. The external-issues operation has noper_page, so that call relies on Sentry's default page size of 100, which is what it used to send.Still on
requestJSON/request()@sentry/apioperation: issue notes (createIssueComment,listIssueComments),getIssueActivity,getIssueUserReports,getEventCommitters.updateIssue,linkNativeExternalIssue,unlinkNativeExternalIssue,unlinkSentryAppExternalIssue,startAutofix.sdkClient()only forwards GETs. Letting it forward write bodies now would be replaced by the 6.1 transport anyway. The generated types also don't fit yet:updateOrganizationIssuemarks every body field required, anddeleteOrganizationIssueIntegrationtypesexternalIssueas a number.?download=1) and its redirect probe stay onrequest(), because they read binary data or the redirect URL rather than JSON.The pnpm catalog moves
@sentry/apifrom 0.420.0 to 0.423.0, the latest published version. #1712 makes the same bump, so either PR can land first. Regenerating the CLI'sapi-schema.jsonandidempotent-operations.jsonagainst 0.423.0 produced no changes.via BYK.
--
View Junior Session in Sentry