[sunnykumarabc01-dev]

Fixes #145

• Tests pass
• Appropriate changes to documentation are included in the PR
  Fixes Boiler Fails with High Outside Air Temp #145

Context & Discussion Analysis

During hot weather conditions (such as Oct 6, 2024), the boiler simulation previously crashed due to strict checks when the outdoor air temperature exceeded the hot water temperature. Based on repository discussions, three architectural approaches were evaluated:

1. Option 1: Remove assertion/error and allow negative dissipation (Recommended & Implemented)

   • Behavior: Returns a negative thermal dissipation rate when outside_temp > water_temp, accurately modeling net heat gain from the environment (ambient pre-heating).
   • Pros: Physically correct, simple, and allows the simulator to automatically adjust boiler demand without crashing.
   • Cons: Callers must correctly interpret negative values in energy balances.

2. Option 2: Clamp to zero (Clamp to Zero)

   • Behavior: Treats dissipation as 0.0 if outside_temp > water_temp.
   • Pros: Avoids negative rates.
   • Cons: Physically incorrect because ambient heat gain during hot days is ignored.

3. Option 3: Make it configurable (allow_ambient_heating boolean)

   • Behavior: Introduces a class attribute to toggle between ambient heating support.
   • Pros: Full backward compatibility.
   • Cons: Adds unnecessary code complexity and API overhead.

We chose Option 1 because it aligns with true thermodynamic principles and cleanly resolves the simulation crash without bloated configuration flags.

Summary of Changes:

• Removed the strict ValueError check in compute_thermal_dissipation_rate inside smart_control/simulator/boiler.py when outside_temp > water_temp.
• Updated the docstring to explicitly document that negative thermal rates indicate net ambient heat gain.
• Disabled obsolete test cases checking for the old value error behavior in boiler_test.py and verified that all 36 unit tests pass successfully.

Acknowledgements

• Thanks to @s2t2 and @Mustaphayinka for analyzing the issue and proposing Option 1.