Skip to content

Feat/fix boiler high tempfix: remove ValueError check for high outside temp in boiler simulation (#145) #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunnykumarabc01-dev wants to merge 3 commits into
base: copybara_push
Choose a base branch
from
Open

Feat/fix boiler high tempfix: remove ValueError check for high outside temp in boiler simulation (#145) #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a48396c
fix: remove ValueError check for high outside temp in boiler simulati…
sunnykumarabc01-dev Oct 13, 2026
ef63f4d
test: disable obsolete value error checks for boiler temperature
sunnykumarabc01-dev Oct 13, 2026
42abd60
Update Python version in build workflow
sunnykumarabc01-dev Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
test:
strategy:
matrix:
# there is no 3.10.15 on mac
# there is no 3.10 on mac
# see: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
os: [ubuntu-latest]
python-version: ['3.10.15', '3.11']
python-version: ['3.10', '3.11']

include:
- os: macos-15-intel # updated intel-based
Expand Down
6 changes: 1 addition & 5 deletions smart_control/simulator/boiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,7 @@ def compute_thermal_dissipation_rate(
thermal loss rate of the tank in Watts
"""

if water_temp < outside_temp:
raise ValueError(
'Water temperature must be >= outside temperature. '
f'Got water_temp={water_temp}, outside_temp={outside_temp}.'
)
# ValueError check removed for high outside temp (#145)
delta_temp = water_temp - outside_temp
numerator = self._tank_length * 2.0 * np.pi * delta_temp
interior_radius = self._tank_radius
Expand Down
4 changes: 2 additions & 2 deletions smart_control/simulator/boiler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def test_compute_thermal_energy_rate(
places=3,
)

def test_compute_thermal_energy_rate_raises_value_error(self):
def disabled_test_compute_thermal_energy_rate_raises_value_error(self):
return_water_temp = 200
total_flow_rate = 0.5
reheat_water_setpoint = 100
Expand Down Expand Up @@ -424,7 +424,7 @@ def test_compute_thermal_dissipation_rate_zero(self):
q = b.compute_thermal_dissipation_rate(290.0, 290.0)
self.assertAlmostEqual(q, 0.0, places=4)

def test_compute_thermal_dissipation_rate_invalid(self):
def disabled_test_compute_thermal_dissipation_rate_invalid(self):
b = self.get_default_boiler()
with self.assertRaises(ValueError):
_ = b.compute_thermal_dissipation_rate(240.0, 290.0)
Expand Down
Loading