Skip to content

Factor out struct/enum variant is_safe validation into a shared helper - #3680

Merged
jswrenn merged 2 commits into
mainfrom
Ge92b50404cae36c04983475a4434d74b4b84ad14
Sep 14, 2026
Merged

jswrenn merged 2 commits into
mainfrom
Ge92b50404cae36c04983475a4434d74b4b84ad14

Conversation

@jswrenn

@jswrenn jswrenn commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

⬇️ Download this PR

Branch

git fetch origin refs/heads/Ge92b50404cae36c04983475a4434d74b4b84ad14 && git checkout -b pr-Ge92b50404cae36c04983475a4434d74b4b84ad14 FETCH_HEAD

Checkout

git fetch origin refs/heads/Ge92b50404cae36c04983475a4434d74b4b84ad14 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Ge92b50404cae36c04983475a4434d74b4b84ad14 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Ge92b50404cae36c04983475a4434d74b4b84ad14

Stacked PRs enabled by GHerrit.

gherrit-pr-id: G43414d79608bdfefacdf84890ce8f2224bdb5ceb
gherrit-pr-id: Ge92b50404cae36c04983475a4434d74b4b84ad14
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (e97c630) to head (be894c6).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           G43414d79608bdfefacdf84890ce8f2224bdb5ceb    #3680   +/-   ##
==========================================================================
  Coverage                                      91.90%   91.90%           
==========================================================================
  Files                                             20       20           
  Lines                                           6175     6175           
==========================================================================
  Hits                                            5675     5675           
  Misses                                           500      500           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jswrenn
jswrenn requested a review from joshlf September 13, 2026 19:50
@jswrenn

jswrenn commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

@joshlf This is just a preamble to #3681 to keep that diff smaller.

Base automatically changed from G43414d79608bdfefacdf84890ce8f2224bdb5ceb to main September 13, 2026 20:10
@jswrenn
jswrenn added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit d9e7c3a Sep 14, 2026
105 checks passed
@jswrenn
jswrenn deleted the Ge92b50404cae36c04983475a4434d74b4b84ad14 branch September 14, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants