Conversation
This was referenced Sep 13, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## G2cef62dbb236b18953ded9a3d514bf0913c0e49c #3682 +/- ##
=============================================================================
+ Coverage 91.90% 92.20% +0.29%
=============================================================================
Files 20 20
Lines 6177 6257 +80
=============================================================================
+ Hits 5677 5769 +92
+ Misses 500 488 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
approved these changes
Sep 13, 2026
| /// does not require `T: Immutable`. | ||
| /// | ||
| /// [`Immutable`]: crate::Immutable | ||
| #[derive(Copy, Default)] |
Member
There was a problem hiding this comment.
I'd prefer to manually implement Default. While it'd obviously be ridiculous, in theory the derive could emit code which violates the invariant after constructing its return value and before returning.
gherrit-pr-id: Gfa0cb30780189c43bb84da57a9ade4d5a9754223
jswrenn
force-pushed
the
Gfa0cb30780189c43bb84da57a9ade4d5a9754223
branch
from
September 16, 2026 18:33
313aadb to
f72412b
Compare
jswrenn
force-pushed
the
G2cef62dbb236b18953ded9a3d514bf0913c0e49c
branch
from
September 16, 2026 18:33
6a2d740 to
32a19cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadOnly#3682#[zerocopy(invariant(...))]library invariant checking #3681Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git checkout -b pr-Gfa0cb30780189c43bb84da57a9ade4d5a9754223 FETCH_HEADCheckout
git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.