Skip to content

Implement common traits for ReadOnly - #3682

Open
jswrenn wants to merge 1 commit into
G2cef62dbb236b18953ded9a3d514bf0913c0e49cfrom
Gfa0cb30780189c43bb84da57a9ade4d5a9754223
Open

jswrenn wants to merge 1 commit into
G2cef62dbb236b18953ded9a3d514bf0913c0e49cfrom
Gfa0cb30780189c43bb84da57a9ade4d5a9754223

Conversation

@jswrenn

@jswrenn jswrenn commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git checkout -b pr-Gfa0cb30780189c43bb84da57a9ade4d5a9754223 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gfa0cb30780189c43bb84da57a9ade4d5a9754223

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (32a19cb) to head (f72412b).

Files with missing lines Patch % Lines
zerocopy/src/wrappers.rs 97.56% 2 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           G2cef62dbb236b18953ded9a3d514bf0913c0e49c    #3682      +/-   ##
=============================================================================
+ Coverage                                      91.90%   92.20%   +0.29%     
=============================================================================
  Files                                             20       20              
  Lines                                           6177     6257      +80     
=============================================================================
+ Hits                                            5677     5769      +92     
+ Misses                                           500      488      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread zerocopy/src/wrappers.rs
/// does not require `T: Immutable`.
///
/// [`Immutable`]: crate::Immutable
#[derive(Copy, Default)]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to manually implement Default. While it'd obviously be ridiculous, in theory the derive could emit code which violates the invariant after constructing its return value and before returning.

gherrit-pr-id: Gfa0cb30780189c43bb84da57a9ade4d5a9754223
@jswrenn
jswrenn force-pushed the Gfa0cb30780189c43bb84da57a9ade4d5a9754223 branch from 313aadb to f72412b Compare September 16, 2026 18:33
@jswrenn
jswrenn force-pushed the G2cef62dbb236b18953ded9a3d514bf0913c0e49c branch from 6a2d740 to 32a19cb Compare September 16, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants