Skip to content

FE-1724: Remove the model-facing Brunch question marker - #9741

Closed
kostandinang wants to merge 5 commits into
kostandin/fe-1712-stabilize-gpt-live-full-duplex-voice-feedbackfrom
kostandin/fe-1724-remove-the-model-facing-brunch-question-marker
Closed

kostandinang wants to merge 5 commits into
kostandin/fe-1712-stabilize-gpt-live-full-duplex-voice-feedbackfrom
kostandin/fe-1724-remove-the-model-facing-brunch-question-marker

Conversation

@kostandinang

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Remove the model-facing question replay marker so direct questions no longer require a marker tool call and extra model completion.

🔗 Related links

🚫 Blocked by

🔍 What does this change?

  • Stops mounting, prompting, and cataloguing both question-marker tool names.
  • Preserves legacy marker parsing and hiding for existing conversation history.
  • Verifies new questions complete in one provider call without marker data while full-response playback remains available.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

New responses intentionally do not offer “Repeat question”; historical marked questions remain compatible.

🐾 Next steps

None.

🛡 What tests cover this?

  • Core and transport unit tests for absent mounting and legacy projection.
  • Website Voice tests for full-response speech without a repeatable question segment.
  • Brunch integration tests for a marker-free, single-completion question turn.

❓ How to test this?

  1. Run the affected unit and integration suites.
  2. Ask a direct question through Brunch.
  3. Confirm the response completes normally without a marker tool call and remains available to “Read full response”.

📹 Demo

Not applicable; this removes internal tool orchestration without changing the rendered response.

Made with Cursor

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Sep 15, 2026 3:10pm UTC
petrinaut Ready Ready Preview Sep 15, 2026 3:10pm UTC
petrinaut-docs Ready Ready Preview Sep 15, 2026 3:10pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Sep 15, 2026 3:10pm UTC

Request Review

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/tests New or updated tests area/apps labels Sep 15, 2026
@kostandinang
kostandinang added this pull request to stack #9737 September 15, 2026 14:52
@kostandinang kostandinang self-assigned this Sep 15, 2026
@kostandinang
kostandinang marked this pull request as ready for review September 15, 2026 14:53
lunelson
lunelson previously approved these changes Sep 15, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

kostandinang and others added 2 commits September 15, 2026 17:01
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@kostandinang
kostandinang force-pushed the kostandin/fe-1724-remove-the-model-facing-brunch-question-marker branch from 1da0764 to 8173c53 Compare September 15, 2026 15:02
@github-actions github-actions Bot added the type/eng > backend Owned by the @backend team label Sep 15, 2026
@kostandinang
kostandinang removed this pull request from stack #9737 September 15, 2026 15:03
@kostandinang

Copy link
Copy Markdown
Contributor Author

GitHub locks base changes for PRs in a native stack. Closing this copy so FE-1724 can be recreated directly against main without disturbing the queued Voice stack.

@kostandinang

Copy link
Copy Markdown
Contributor Author

Superseded by #9742, recreated directly against main. The original review fix is included in the rebased branch.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8173c53. Configure here.

seed: experiment.seed,
// Nothing computes until a control moves or an optimizer navigates.
startComputing: false,
requireSuccessfulRuns: experiment.requestActive === true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweep keeps host-only success requirement

Medium Severity

requireSuccessfulRuns is fixed to true for the whole sweep session when a host request creates the experiment. After the assistant captures its result, requestActive is cleared and users are allowed to explore, but any later batch with a failed run still errors the experiment. User-created sweeps do not behave this way, so inspecting an AI optimization after completion can lock the experiment in an error state.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8173c53. Configure here.

@kostandinang
kostandinang deleted the kostandin/fe-1724-remove-the-model-facing-brunch-question-marker branch September 15, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

3 participants