Skip to content

FE-1724: Remove the model-facing Brunch question marker - #9742

Merged
kostandinang merged 2 commits into
mainfrom
kostandin/fe-1724-remove-the-model-facing-brunch-question-marker
Sep 15, 2026
Merged

kostandinang merged 2 commits into
mainfrom
kostandin/fe-1724-remove-the-model-facing-brunch-question-marker

Conversation

@kostandinang

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Remove the model-facing question replay marker so direct questions no longer require a marker tool call and extra model completion.

🔗 Related links

  • FE-1724 (internal)
  • Supersedes #9741, which GitHub locked to the Voice stack

🚫 Blocked by

  • None.

🔍 What does this change?

  • Stops mounting, prompting, and cataloguing both question-marker tool names.
  • Preserves legacy marker parsing and hiding for existing conversation history.
  • Verifies new questions complete in one provider call without marker data while full-response playback remains available.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

New responses intentionally do not offer “Repeat question”; historical marked questions remain compatible.

🐾 Next steps

None.

🛡 What tests cover this?

  • Core and transport unit tests for absent mounting and legacy projection.
  • Website Voice tests for full-response speech without a repeatable question segment.
  • Brunch integration tests for a marker-free, single-completion question turn.

❓ How to test this?

  1. Run the affected unit and integration suites.
  2. Ask a direct question through Brunch.
  3. Confirm the response completes normally without a marker tool call and remains available to “Read full response”.

📹 Demo

Not applicable; this removes internal tool orchestration without changing the rendered response.

Made with Cursor

kostandinang and others added 2 commits September 15, 2026 17:01
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Building Building Preview Sep 15, 2026 3:04pm UTC
petrinaut Building Building Preview Sep 15, 2026 3:04pm UTC
petrinaut-docs Building Building Preview Sep 15, 2026 3:04pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Sep 15, 2026 3:04pm UTC

Request Review

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/tests New or updated tests area/apps labels Sep 15, 2026
@kostandinang kostandinang self-assigned this Sep 15, 2026
@kostandinang
kostandinang marked this pull request as ready for review September 15, 2026 15:05
@kostandinang
kostandinang added this pull request to the merge queue Sep 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2026
@kostandinang
kostandinang added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit 921598d Sep 15, 2026
76 checks passed
@kostandinang
kostandinang deleted the kostandin/fe-1724-remove-the-model-facing-brunch-question-marker branch September 15, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants