Repository navigation
feat(app): mascot cheers when its bot finishes - #145
Merged
Merged
Conversation
When a bot goes from working to idle, its mascot crouches, jumps up stretched, lands squashed and smiles with its eyes bent into two arcs, then opens them again with a blink (1.2 s). A mascot that shows up idle does not cheer. The motion lives in its own file, mascot-cheer.css, and every frame ends at rest, so less motion shows nothing.
The open eyes sit on a line that rises to the right (about 14 degrees), but the arcs of the shut and smiling eyes were drawn level, so they looked crooked next to it. Both arcs now turn by the angle of that line, in a group of their own so the smile's CSS transform keeps the turn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a bot finishes what it was doing (its mood goes from working to idle), its mascot cheers once, for 1.2 s:
The arcs of the smiling eyes, and of the shut eyes while asleep, now lean with the line through the open eyes (about 14 degrees, rising to the right) instead of lying level.
A mascot that shows up idle does not cheer; nor does one coming back from waiting or tired. The motion is in its own file,
mascot-cheer.css(motion.cssandmascot.cssdo not grow). Every keyframe ends at rest, so less motion, which cuts animations to their end, shows nothing. Spec 15.3 describes it.Tests
avatar.test.tsx: cheers on working → idle and stops afterCHEER_MS; no cheer on mount or waiting → idle; each cheer animation ends at rest.Manual check with real Claude Code