Repository navigation
feat(catalog): the chief reads the bot catalog and suggests from a role (G2) - #205
Merged
Merged
Conversation
list_bot_templates and get_bot_template (chief only) and a template field on suggest_bot. A suggestion with a template is resolved before the owner is asked: the sheet's role, instructions, model and effort fill what is missing and the chief's instructions follow under 'For this crew'. The card and the owner's edits see a plain suggestion. The chief's rules tell it to look at the catalog first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
G2 of the bot catalog (spec 26.4).
list_bot_templatesandget_bot_template: the chief reads the catalog. Other bots get the usual "ask the chief" error.suggest_bottakes an optionaltemplate(an id of the catalog). The daemon resolves it before asking the owner: the sheet's role, instructions, model and effort fill what is missing, and the chief'sinstructionsfollow under "For this crew:". The approval card and the owner's edits see a plain suggestion, so the app needs no change.templategoes back to the chief as an error, without bothering the owner. Withouttemplate,roleandinstructionsstay required. The 8 000 character limit applies to the final text.Tests
cargo test --workspace(548), clippy-D warnings,cargo fmt --check. Five new tests inchief_catalog.rs: reading and filtering, chief only, a suggestion from a role (card, creation, plain bot), the chief's text after the sheet's with model and effort precedence, and the errors that never reach the owner.mcp.rscounts 40 tools now.Manual test (real Claude Code)
With a running crew and its chief: ask the chief for "someone to handle the social media". Check that it calls
list_bot_templates(andget_bot_template), thensuggest_botwithtemplate: "social-media", and that the card in its chat shows the sheet's instructions and lets you edit them before approving. Depends on the model's choices, soFakeRuntimecannot prove it.Next
G3: the Bot agency screen in the app (cards, Learn more, Add to crew, three languages).