Repository navigation
fix(app): side panels no longer cover the chat; resizable; chat fills the width - #31
Merged
Merged
Conversation
… the width The chat section could not shrink below its content, so an open panel sat under it. Details and Files now share a SidePanel the owner drags (or arrows) to resize, remembered per panel, and the chat is no longer a centered 48rem column. Spec 15.1, 15.3.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the About (Details) or Files panel open, the chat text ran under the panel. The chat section could not shrink below its own content (
min-width: autoon a flex item), so it overflowed the space left for it and, beingrelative, painted over the panel. The panels also had a fixed width, and the chat was a centered 48rem column, which left a lot of empty space on the left.Change
ChatViewgetsmin-w-0, so it shrinks with the panel. Reproduced at the reporter's window width (chat section 456 px inside a 257 px tab panel) and checked after the fix (both 337 px, panel right after it).ui/SidePanel: Details and Files share it. Drag the left edge, or use ←/→ (Shift for bigger steps); double click resets. 256–900 px, and CSS keeps at least 22rem for the chat. The width is kept per panel inlocalStorage. The drag divides by the window's zoom, so it follows the pointer at any size.Tested
pnpm check(118 tests; three new for resizing and its limits). Checked in the dev preview: no overlap, drag from 320 to 480 px stored the width, chat fills the space with the panel closed.Not in this PR
The crews sidebar is still fixed-width, and at very narrow windows the bot header squeezes the name. Both would be their own change.