Repository navigation
fix(app): the mascot fills its avatar as the first one did - #36
Merged
Merged
Conversation
The shaded artwork kept the canvas it was drawn on, so the body filled only 71% of the avatar's height (the first mascot filled 96%) and every mascot looked a quarter smaller. The view box is now a square just around the body with the old margin; hops and sparks go past it, as the SVG shows its overflow.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new shaded mascot (#34) kept the square canvas it was drawn on (860 units for a body 610 tall), so the body filled 71% of the avatar's height where the first mascot filled 96%. Every mascot looked about a quarter smaller.
VIEW_BOXis now a square just around the body, with the same thin margin as before. Hops (fill-boxpercentages) are unchanged. Sparks rise past the box, which the avatar's SVG already shows (overflow-visible). The app icon square (framed) keeps its own box.pnpm checkpasses.