Repository navigation
feat: tools read as plain actions in the owner's language - #39
Merged
Merged
Conversation
…emon A tool's summary is only what its input says (the command, the file, @writer, a key), empty where words would be needed (TodoWrite, complete_task, a ToolSearch that loads tools, a scroll's direction) or where it means nothing to the owner (an element ref). The conversation list line no longer starts with the tool's name: it comes apart in Activity.tool, for the app to name in the owner's language. Spec 8.2, 11 and 15.6.
The chat's tool lines, the requests to allow a tool and the conversation
list name each tool as an action in the owner's language ("Mandar uma
mensagem", "Abrir uma página", "Rodar um comando") instead of its
identifier. Where the daemon leaves the detail empty, the app says it
from the input: the tools a ToolSearch loads, a scroll's direction. An
unknown tool shows by its name. Approvals read "Scout quer rodar um
comando" and "Permitido: escrever um arquivo".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The app showed tool identifiers to the owner (
send_message,browser_open,Write,Bash), and some summaries came with English words from the daemon ("to @writer", "Updated the plan", "load send_message, Read"). Now every tool reads as a plain action in the owner's language.Daemon and core (spec 8.2, 11, 15.6)
tool_summarykeeps only what the input says: the command, the file,@writer, a key.TodoWrite,complete_task, aToolSearchthat loads tools, and a scroll's direction.e4.Activitygainstool. The list line'stextis now only the summary, and the app names the tool. The line is computed from the chat on read, so there is no migration.App
toolstext area in the three languages. Each tool is an action, which reads right while it runs and after: "Mandar uma mensagem", "Abrir uma página", "Rodar um comando", "Escrever um arquivo".toolNames.tsgives:ToolSearchloads, a scroll's direction. Items saved before this change also read right.Tests
pnpm checkpasses (147 tests). NewtoolNames.test.tsxcovers:constructor;