Repository navigation
feat: the owner chooses how long a request for permission waits - #42
Merged
Merged
Conversation
settings.update takes approvalWaitMinutes (1 to 1440) and saves it as bots.approval_timeout_minutes, keeping a comment after the old value. The wait is live: the next request waits the new time, and a longer one restarts each bot once nothing is in progress, since Claude Code reads the timeout in mcp.json when it starts. Settings, Chat offers 15 min to 8 hours, plus a value set by hand.
# Conflicts: # docs/spec.md
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #41: it adds a choice to the Chat part of Settings.
What
Settings → Chat gets How long a request for permission waits for you, with 15 min, 30 min, 1 hour, 2, 4 or 8 hours. The line under it says that, with no answer by then, the bot's request is denied. A value set by hand in
config.tomlshows up in the list too.How
settings.getandsettings.updategainapprovalWaitMinutes.bots.approval_timeout_minutes, and a comment after the old value stays.LiveSettingsand has leftBotSettings. Approvals andworkspace_envread the current value.mcp.json, which Claude Code only reads when it starts. SoSupervisor::workspace_settings_changedrestarts every running bot once nothing is in progress, and the bot resumes its conversation (the same path as a mode change).Tests
cargo test,clippy -D warnings,fmtandpnpm checkpass (163 app tests).timeoutinmcp.jsonafter a longer wait; a shorter wait restarts nothing.[bots].Manual step still open
timeout(8 h 2 min, about 28.9 million ms) is still below the 2^31 ms limit of Node's timers.