Repository navigation
feat(installer): Botloft's own look, with no third-party names - #45
Merged
Merged
Conversation
The installer and uninstaller use the app icon instead of NSIS's own; the welcome and finish pages get a black side image with the mascot and the name, and the other pages the mascot in the header, on the right. Both images come from app-icon.svg without its square. The footer shows the copyright instead of "Nullsoft Install System", and a post-install hook writes Botloft as the publisher in Installed apps. bundle.publisher stays unset on purpose: Tauri also names the registry key that keeps the install folder after it, so changing it would make the first update of an existing install run the old uninstaller without its folder. Spec 15.4 follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The installer used Tauri's default NSIS setup with nothing of ours, so it showed third-party names and art. Now:
windows/installer-sidebar.bmp, 164×314).windows/installer-header.bmp, 150×57, withMUI_HEADERIMAGE_RIGHTin the hooks file).bundle.copyright) instead of "Nullsoft Install System v3.11". The same text goes into the file properties ofBotloft.exeand the setup.NSIS_HOOK_POSTINSTALL.Both images come from
app-icon.svgwithout its black square.Why the publisher is set in a hook
bundle.publisherstays unset on purpose. Tauri also names the registry key that keeps the install folder after it (Software\<publisher>\Botloft, todaygithub, the second part of the identifier). During an update, the new installer reads that key to run the old uninstaller with_?=<folder>. With a new name the key would be empty on the first update, and the old uninstaller would run without its folder, possibly while the new files are written. The hook changes only what Installed apps shows. The one visible leftover is "github" as the company inBotloft.exe's file properties.Spec 15.4 describes it.
Tests
pnpm bundlebuiltBotloft_0.5.0_x64-setup.exe; only the updater signature step failed locally, since the private key lives in CI.Still to try by hand