Repository navigation
fix(core): load the compositional models and unbreak the build tree - #216
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fork governance
🟣 critical · commit
Hypatia scan: 141 finding(s)
panic-attack assail: 19 finding(s)
pons asinorum: 10 finding(s)
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
panicbot (panic recovery, error handling): not_run — enrolled, but no report-back was received
echidnabot (formal verification: proofs/): not_run — enrolled, but no report-back was received
seambot (integration health: API routes): not_run — enrolled, but no report-back was received
finishingbot (release readiness): not_run — enrolled, but no report-back was received
accessibilitybot (WCAG on the React UI): not_run — enrolled, but no report-back was received
glambot (presentation quality): not_run — enrolled, but no report-back was received
cipherbot: not_applicable — no cryptography is implemented in this repository
sustainabot: not_applicable — fleet adapter slot reserved; no adapter exists yet (gitbot-fleet README)
Scope: static findings reported by each row's tool at the named commit. Purple, red, yellow and blue grade the worst finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
… handling `ROADMAP.md` still said that `nb_glm` and `clr_welch` "remain the existing differential methods", which stopped being true when `zinb`, `hurdle_nb`, `ancom_bc`, `aldex2`, `songbird`, `multinomial` and `dirichlet_multinomial` landed. It now lists all nine and points at the README section, and records that `songbird` (R) and `multinomial` (Julia) are two implementations of one baseline-category model rather than two models. The zero-handling note explained why a negative-binomial likelihood needs no replacement but said nothing about the two joint multinomial models, whose "when not to replace zeros" advice now names them: a zero count is part of the likelihood, no size factor is fitted, and conditioning on each sample's read total makes every effect a log ratio against a reference taxon. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
b1022be to
a840c5e
Compare
|



What is broken on
mainusing MetaManifoldfails onc978994, so the Julia suite cannot run at all. Two merge artefacts are left over from the compositional-differential work:src/core/doi.jlmodule DOIdeclared twice (lines 4 and 21). The inner declaration swallows the module body and leaves the outer one without anend, so the file cannot be included.src/MetaManifold.jlanalysis/clade_cumulus.jlincluded twice, andanalysis/compositional.jlnever included.Differentialdoesusing ..CompositionalModels, so loading dies withUndefVarError: CompositionalModels not defined.The routes (
#211), the frontend and the unit tests are already correct; this is the remaining piece that keeps the package from loading, plus the documentation the merge dropped.Changes
src/core/doi.jl— remove the duplicatedmodule DOI.src/MetaManifold.jl— drop the duplicateclade_cumulusinclude; includeanalysis/compositional.jlbeforeanalysis/differential.jl, with a comment explaining the ordering requirement.README.md— restore theancom_bc,aldex2,songbird,multinomialanddirichlet_multinomialmethod bullets, the "why a count model", "choosing the reference taxon" and "overdispersion" sections, and the nine-methodanalysis.differentialconfig block (includingmn_reference_taxon,mn_penalty,dm_overdispersion_method,max_iter,tolerance,max_seconds).ROADMAP.md,docs/statistics/zero-handling.md— describe the five compositional models and note that the multinomial models replace no zero.songbird(R) andmultinomial(Julia) remain two implementations of the same baseline-category model, both selectable, neither an alias — as documented insrc/analysis/differential.jl.Verification
./node_modules/.bin/tsc --noEmit -p .— 0 errors.bun test src— 85 pass / 0 fail.tree-sitter-juliaparse of everysrc/**/*.jlandtest/**/*.jl— clean (same three known parser false positives as before).Differential.x/CompositionalModels.xreference resolves.test/runtests.jlruns here in CI for the first time since the merge.Known, out of scope
src/server/routes/cladistics.jlis not included bysrc/server/server.jl, and it callsCladeCumulus.asv_tip_name/CladeCumulus.analyse_phylogeny, which do not exist. Wiring it in as-is would break the server, so it is left untouched; the Cladistics build API needs a follow-up.