Repository navigation
fix(ci): give the Security Status aggregator its own workflow file - #933
hyperpolymath wants to merge 1 commit into
Conversation
The orphan-job self-check (#850) parses .github/workflows/security-policy.yml, but the security-status job had no checkout, so awk and sed found no file and the step exited 2. The verdict step after it was skipped on every run, which left the aggregator red without ever consulting its eight scans. A sparse checkout of just that file, with persist-credentials off, lets the self-check run. actions/checkout@v7.0.1 is already in actions.lock for this workflow, so the lock does not change. Checked locally: the self-check script passes against the edited file (9 jobs, all 8 non-aggregators named in needs:). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LET2eHeDbN3b4WuxYjMUX9
|
Expected reds on this PR. None of them come from this change, which adds a single checkout step to
I'm not copying #929's repin into this PR. That would turn this one-step fix into a duplicate of #929, along with its baseline gate. Instead, this commit is already ported into #929 as 5c27a59. On #929's head every scan job feeding Either merge order works:
Generated by Claude Code |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
What
Adds one step to the
security-statusjob in.github/workflows/security-policy.yml: a sparse checkout of that workflow file, withpersist-credentials: false.Why
The orphan-job self-check (#850) parses
.github/workflows/security-policy.yml, but the job had no checkout. So the step fails on every run:That leaves the aggregator red for the wrong reason, and the verdict step after it is skipped. The aggregator never actually consults its eight scans. This happens on
main(5173ca7, 2bc2103, fd7db07) and on every PR.Checks
actions/checkout@v7.0.1is already listed inactions.lockfor this workflow, so the lock is unchanged.needs:, and prints "ok".What to expect on this PR
Once the self-check passes, the verdict step will run. It will still report Security Status as failed on
main's tree, correctly, becauserust-auditandrust-denyfail onmain. #929 fixes both, with lock bumps and a current-schemadeny.toml. On #929's head every scan job is already green, so this change plus #929 should turn Security Status green. The same step is ported into #929.Generated by Claude Code