Repository navigation
fix(js-runtimes): make the crate its own workspace root - #1299
Conversation
The governance and js-runtimes reusables check tools/js-runtimes out at .standards-js/ inside the caller's checkout, then run `cargo install --locked --path` on it. When the caller's root Cargo.toml is a workspace, cargo walks up from the staged crate, finds that workspace, and refuses: error: current package believes it's in a workspace when it's not So "JS runtimes — environment provisions Bun first" fails on any Rust-workspace consumer pinned at 75bd599; hyperpolymath/hypatia#929 hit it first. Callers without a root workspace, such as palimpsest-license, pass. An empty [workspace] table makes the crate its own root wherever it is staged. Standards has no root workspace, so nothing changes here: the lockfile is untouched, and `cargo test --locked` still passes (8 tests). Checked in a probe repository with a root workspace and the crate staged at .standards-js/tools/js-runtimes: `cargo metadata` fails (101) with the current manifest and passes with this one, and the job's `cargo install --locked` now builds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LET2eHeDbN3b4WuxYjMUX9
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🟢 conformant · commit
K9 live corpus (L0–L2): 2 finding(s) / scope notes
Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
Add Carrot credits or activate Agent usage billing to use Autofix |
…one entry The two CI-fix commits each added the same `.standards-js/tools/js-runtimes` line with its own comment. One entry, with a note on why it exists and when it can go (the governance pin reaching hyperpolymath/standards#1299, which makes that crate its own workspace root). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
#440 carries the same exclude (its CI-fix commit 78a70c2) and merges first; byte-identical text here means the two land without a conflict. It can go once the governance pin reaches hyperpolymath/standards#1299, which makes that crate its own workspace root. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3



Why
governance-reusable.ymlandjs-runtimes-reusable.ymlchecktools/js-runtimesout at.standards-js/inside the caller's checkout, then runcargo install --locked --pathon it. When the caller's rootCargo.tomlis a workspace, cargo walks up from the staged crate, finds that workspace, and refuses:So
governance / JS runtimes — environment provisions Bun firstfails on every Rust-workspace consumer pinned at 75bd599. hyperpolymath/hypatia#929 hit it first. Callers without a root workspace pass, for example hyperpolymath/palimpsest-license#187.What
tools/js-runtimes/Cargo.tomlgains an empty[workspace]table, with a comment saying why. That makes the crate its own workspace root wherever it is staged.Standards has no root
Cargo.toml, so nothing changes in this repository:Cargo.lockis untouched.Verified
.standards-js/tools/js-runtimes:cargo metadata: exit 101 with the current manifest, 0 with this one;cargo install --quiet --locked --path …: builds.cargo test --locked --manifest-path tools/js-runtimes/Cargo.tomlpasses (8 tests).hypatia#929 carries a consumer-side
exclude = [".standards-js"]so it can go green before this lands. That exclude is harmless afterwards. Other Rust-workspace repos need this fix before the estate-wide repin.Generated by Claude Code