Skip to content

fix(js-runtimes): make the crate its own workspace root - #1299

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/js-runtimes-own-workspace
Oct 19, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
claude/js-runtimes-own-workspace

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

governance-reusable.yml and js-runtimes-reusable.yml check tools/js-runtimes out at .standards-js/ inside the caller's checkout, then run cargo install --locked --path on it. When the caller's root Cargo.toml is a workspace, cargo walks up from the staged crate, finds that workspace, and refuses:

error: current package believes it's in a workspace when it's not:
current:   /home/runner/work/hypatia/hypatia/.standards-js/tools/js-runtimes/Cargo.toml
workspace: /home/runner/work/hypatia/hypatia/Cargo.toml

So governance / JS runtimes — environment provisions Bun first fails on every Rust-workspace consumer pinned at 75bd599. hyperpolymath/hypatia#929 hit it first. Callers without a root workspace pass, for example hyperpolymath/palimpsest-license#187.

What

tools/js-runtimes/Cargo.toml gains an empty [workspace] table, with a comment saying why. That makes the crate its own workspace root wherever it is staged.

Standards has no root Cargo.toml, so nothing changes in this repository: Cargo.lock is untouched.

Verified

  • In a probe repository with a root workspace and the crate staged at .standards-js/tools/js-runtimes:
    • cargo metadata: exit 101 with the current manifest, 0 with this one;
    • the job's own cargo install --quiet --locked --path …: builds.
  • In standards: cargo test --locked --manifest-path tools/js-runtimes/Cargo.toml passes (8 tests).

hypatia#929 carries a consumer-side exclude = [".standards-js"] so it can go green before this lands. That exclude is harmless afterwards. Other Rust-workspace repos need this fix before the estate-wide repin.


Generated by Claude Code

The governance and js-runtimes reusables check tools/js-runtimes out at
.standards-js/ inside the caller's checkout, then run
`cargo install --locked --path` on it. When the caller's root Cargo.toml
is a workspace, cargo walks up from the staged crate, finds that
workspace, and refuses:

  error: current package believes it's in a workspace when it's not

So "JS runtimes — environment provisions Bun first" fails on any
Rust-workspace consumer pinned at 75bd599; hyperpolymath/hypatia#929 hit
it first. Callers without a root workspace, such as palimpsest-license,
pass.

An empty [workspace] table makes the crate its own root wherever it is
staged. Standards has no root workspace, so nothing changes here: the
lockfile is untouched, and `cargo test --locked` still passes (8 tests).

Checked in a probe repository with a root workspace and the crate staged
at .standards-js/tools/js-runtimes: `cargo metadata` fails (101) with the
current manifest and passes with this one, and the job's
`cargo install --locked` now builds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LET2eHeDbN3b4WuxYjMUX9
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f39e4f75-bfbb-41fb-b7eb-92796310edce
📥 Commits

Reviewing files that changed from the base of the PR and between 75bd599 and 4a6e59f.

📒 Files selected for processing: 1
  • tools/js-runtimes/Cargo.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

DEED–K9 green

🟢 conformant · commit a805e66b5bb5 · run 39274479842

Category Status Pass Fail Indeterminate N/A Since previous revision
DEED syntax 🟢 conformant 4 0 0 0 ↔ unchanged
K9 contract typecheck 🟢 conformant 1 0 0 0 ↔ unchanged
K9 validator self-test 🟢 conformant 34 0 0 0 ↔ unchanged
K9 positive/negative controls 🟢 conformant 27 0 0 0 ↔ unchanged
K9 live corpus (L0–L2) 🟢 conformant 12 0 0 2 ↔ unchanged
K9 live corpus (L0–L2): 2 finding(s) / scope notes
  • 2-protocols/k9-coordination/examples/minimal.k9 — not_applicable: Routed to another dialect; not validated as a K9 contract.
  • coordination.k9 — not_applicable: Routed to another dialect; not validated as a K9 contract.

Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review October 19, 2026 12:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:04:53.071496Z a805e66 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 19, 2026 15:03
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 1fed802 into main Oct 19, 2026
65 of 67 checks passed
@hyperpolymath
hyperpolymath deleted the claude/js-runtimes-own-workspace branch October 19, 2026 15:04
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

hyperpolymath pushed a commit to hyperpolymath/echidna that referenced this pull request Oct 19, 2026
…one entry

The two CI-fix commits each added the same `.standards-js/tools/js-runtimes`
line with its own comment. One entry, with a note on why it exists and when
it can go (the governance pin reaching hyperpolymath/standards#1299, which
makes that crate its own workspace root).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
hyperpolymath pushed a commit to hyperpolymath/echidna that referenced this pull request Oct 19, 2026
#440 carries the same exclude (its CI-fix commit 78a70c2) and merges first;
byte-identical text here means the two land without a conflict. It can go
once the governance pin reaches hyperpolymath/standards#1299, which makes
that crate its own workspace root.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants