Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only minor editorial nits remain; no blocking issues were identified.
Pull request overview
Editorial update to IRR prefix-filter guidance, clarifying ROUTE/ROUTE6 semantics and AS-SET usage while adding RFC 2622.
Changes:
- Clarifies exact-prefix matching and multiple origin ASNs.
- Reframes AS-SET usage and corrects wording.
- Adds RFC 2622 as an informative reference.
File summaries
| File | Summary | Final comments |
|---|---|---|
draft-ietf-grow-routing-ops-sec-inform.xml |
Updates IRR and AS-SET descriptions and references. | Two nit comments remain at line 471/478: clarify the cone sentence (3 votes) and correct the remaining “different IRR may” grammar issue (2 votes). |
Review details
Suppressed comments (2)
draft-ietf-grow-routing-ops-sec-inform.xml:471
- Because an AS-SET contains AS numbers or nested AS-SETs, the recursively represented customer cone is a set of ASes; prefixes are derived only by the subsequent ROUTE lookup. Calling the cone itself “the set of all prefixes” makes this clarification factually misleading. Describe the cone as the set of downstream ASes and then explain that it is used to derive prefixes.
A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.
draft-ietf-grow-routing-ops-sec-inform.xml:493
- RFC 2622 Section 5.3 defines route-set objects, but neither this sentence nor the following macro-algorithm mentions route sets; it describes only AS-SET and ROUTE/ROUTE6 objects. The new citation is therefore unsupported here and the stated route-set clarification is missing. Either add route-set objects to the described filter inputs and algorithm or cite the relevant AS-SET/route definitions instead.
Using AS-SETs and ROUTE/ROUTE6 objects, it is possible to use the IRR information to build, for a given neighbor AS, a list of prefixes the neighbor is authorized to originate or transit <xref target="RFC2622" format="default" section="5.3"/>.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <t> | ||
| An AS-SET is an object that contains AS numbers or other AS-SETs. | ||
| The purpose of AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS. | ||
| A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS. |
| <t> | ||
| An AS-SET is an object that contains AS numbers or other AS-SETs. | ||
| The purpose of AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS. | ||
| A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS. |
edit: add RFC2622 to references
Contributor
Author
|
LLM jumped the gun during revision pass. Will open a new one after fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small editorial pass on the "Prefix Filters Created from IRRs" section:
💘 Generated with Crush
Assisted-by: Crush:glm-5.3