Skip to content

Clarify IRR route object and AS-SET descriptions - #18

Closed
cunha wants to merge 3 commits into
ichdasich:mainfrom
cunha:minor-edits
Closed

cunha wants to merge 3 commits into
ichdasich:mainfrom
cunha:minor-edits

Conversation

@cunha

@cunha cunha commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Small editorial pass on the "Prefix Filters Created from IRRs" section:

  • Expands the ROUTE/ROUTE6 object description: exact-prefix-match semantics, multiple origin ASNs per prefix, and coexistence of objects for more- and less-specific prefixes.
  • Rephrases the purpose of AS-SETs: documenting the cone is a common use, not the only purpose.
  • Fixes typos and grammar ("authorized to originated or transited", "prefixes they do or do plan to originate", "different IRR may").
  • Adds RFC 2622 as an informative reference, cited where predefined set objects (route sets containing AS numbers or AS-SETs) are used when computing filters.

💘 Generated with Crush

Assisted-by: Crush:glm-5.3

Copilot AI lite review requested due to automatic review settings August 22, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only minor editorial nits remain; no blocking issues were identified.

Pull request overview

Editorial update to IRR prefix-filter guidance, clarifying ROUTE/ROUTE6 semantics and AS-SET usage while adding RFC 2622.

Changes:

  • Clarifies exact-prefix matching and multiple origin ASNs.
  • Reframes AS-SET usage and corrects wording.
  • Adds RFC 2622 as an informative reference.
File summaries
File Summary Final comments
draft-ietf-grow-routing-ops-sec-inform.xml Updates IRR and AS-SET descriptions and references. Two nit comments remain at line 471/478: clarify the cone sentence (3 votes) and correct the remaining “different IRR may” grammar issue (2 votes).
Review details

Suppressed comments (2)

draft-ietf-grow-routing-ops-sec-inform.xml:471

  • Because an AS-SET contains AS numbers or nested AS-SETs, the recursively represented customer cone is a set of ASes; prefixes are derived only by the subsequent ROUTE lookup. Calling the cone itself “the set of all prefixes” makes this clarification factually misleading. Describe the cone as the set of downstream ASes and then explain that it is used to derive prefixes.
                        A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.

draft-ietf-grow-routing-ops-sec-inform.xml:493

  • RFC 2622 Section 5.3 defines route-set objects, but neither this sentence nor the following macro-algorithm mentions route sets; it describes only AS-SET and ROUTE/ROUTE6 objects. The new citation is therefore unsupported here and the stated route-set clarification is missing. Either add route-set objects to the described filter inputs and algorithm or cite the relevant AS-SET/route definitions instead.
                        Using AS-SETs and ROUTE/ROUTE6 objects, it is possible to use the IRR information to build, for a given neighbor AS, a list of prefixes the neighbor is authorized to originate or transit <xref target="RFC2622" format="default" section="5.3"/>.
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<t>
An AS-SET is an object that contains AS numbers or other AS-SETs.
The purpose of AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.
A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.
<t>
An AS-SET is an object that contains AS numbers or other AS-SETs.
The purpose of AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.
A common use for AS-SETs is creating a recursively queryable structure documenting the cone, i.e., the set of all prefixes announced by the AS itself, or any of its downstreams, of an AS.
@cunha

cunha commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

LLM jumped the gun during revision pass. Will open a new one after fixes.

@cunha cunha closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants