Repository navigation
Isolate platform gateway bundles by target - #49
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughTarget-specific gateway factories are added to the Phaser starter and CLI template. Vite selects and aliases the appropriate factory, platform installation consumes it, and validation checks template parity plus Microsoft Store bundle purity. ChangesTarget-isolated gateway flow
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ViteConfig
participant GatewayResolver
participant PlatformInstaller
participant SelectedGateway
participant PlatformAdapter
ViteConfig->>GatewayResolver: resolve target, debug, and buildId
GatewayResolver->>SelectedGateway: alias `#mpgd-platform-gateway`
PlatformInstaller->>SelectedGateway: createBuildGateway(runtime)
SelectedGateway->>PlatformAdapter: create target gateway
PlatformAdapter-->>PlatformInstaller: return PlatformGateway
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Validation
pnpm checkpnpm build:microsoft-storepnpm smoke:target microsoft-storepnpm build:target ait stagingpnpm build:target reddit stagingpnpm smoke:target ait redditRelease
@mpgd/cli.Summary by CodeRabbit
New Features
Bug Fixes