Repository navigation
feat: add Verse8 target foundation - #82
Conversation
|
@codex review @coderabbitai review |
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds Verse8 as a configured iframe target with a dedicated platform adapter, identity and storage behavior, CLI and starter-template support, build scripts, documentation, notification normalization, and smoke-validation coverage. ChangesVerse8 target foundation
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant BuildGateway
participant createVerse8PlatformGateway
participant Verse8Host
CLI->>BuildGateway: resolve target verse8
BuildGateway->>createVerse8PlatformGateway: create gateway
createVerse8PlatformGateway->>Verse8Host: request verified user
Verse8Host-->>createVerse8PlatformGateway: credential or auth failure
createVerse8PlatformGateway-->>CLI: PlatformGateway
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Action performedReview finished.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30f0af0918
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Patched all five review findings in 4ad8da1 and resolved the addressed threads. @codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@adapters/verse8/package.json`:
- Around line 37-38: Update the package scripts so the lint entry invokes the
`@ttsc/lint` toolchain via the expected “ttsc lint” command, while preserving
“check” as the type-checking command and leaving the sibling format and fix
scripts unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4c63ab8d-a9f2-48a5-b204-15c6d5318494
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.sampo/changesets/verse8-target-foundation.mdREADME.mdadapters/verse8/package.jsonadapters/verse8/src/index.test.tsadapters/verse8/src/index.tsadapters/verse8/tsconfig.jsondocs/GAME_DEVELOPMENT.mdexamples/phaser-starter/agent/brief.template.mdexamples/phaser-starter/agent/game.manifest.jsonexamples/phaser-starter/mpgd.targets.jsonexamples/phaser-starter/package.jsonexamples/phaser-starter/src/platform/buildGateways/verse8.tsexamples/phaser-starter/src/platform/runtimeDetector.tsexamples/phaser-starter/vite.shared.tspackage.jsonpackages/cli/package.jsonpackages/cli/src/index.tspackages/cli/templates/phaser-game/README.mdpackages/cli/templates/phaser-game/agent/brief.mdpackages/cli/templates/phaser-game/agent/game-manifest.jsonpackages/cli/templates/phaser-game/mpgd.targets.jsonpackages/cli/templates/phaser-game/package.jsonpackages/cli/templates/phaser-game/src/platform/buildGateways/verse8.tspackages/cli/templates/phaser-game/src/platform/runtimeDetector.tspackages/cli/templates/phaser-game/vite.shared.tspackages/platform/src/index.tspackages/target-config/src/runtime.tspackages/target-config/src/viewport.tspackages/target-config/targets.jsonpackages/target-config/test/target-config-smoke.tstools/smoke/adapter-effective-config.tstools/smoke/build-target-artifacts.tstools/smoke/effective-target-config.tstools/smoke/target-config-runtime.tstools/target/build-target.tstools/target/effective-config.tstools/validate-starter-workflow.tstools/validate-target-config.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ad8da1872
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the adapter-validation and workflow-coverage findings in cf77bb1. The publishability thread remains open while npm Trusted Publishing is configured. @codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf77bb1ae3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the notification target and target-config version findings in 772c6c0, and resolved the duplicate installability thread with the published npm 0.1.0 evidence. The future-release/OIDC thread remains open pending authenticated Trusted Publisher setup. @codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 772c6c00f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed all three new review findings in d3c717f: stale effective-config entries are pruned, standalone Verse8 adapter resolution is pinned to its published line before the generic fallback, and partial target matrices no longer inherit stale smoke expectations. The future-release/OIDC thread remains open pending authenticated Trusted Publisher setup. @codex review @coderabbitai review |
|
✅ Action performedReview finished.
|
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
d3c717f to
909541f
Compare
|
Resolved the final publishability thread in 909541f after rebasing onto the latest main. npm Trusted Publishing, public package metadata, Sampo registration, and the adapter changeset are now in place. Full type checks, public readiness, package packing, and isolated-main Sampo dry-run pass. @codex review @coderabbitai review |
|
(=^･ω･^=) ﾉ ✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/PUBLIC_RELEASE_CHECKLIST.md`:
- Around line 41-42: Update the Validation/Release Artifacts command list in
PUBLIC_RELEASE_CHECKLIST to include both `pnpm build:verse8` and `pnpm
smoke:target verse8`, matching the commands documented in README.md and ensuring
Verse8 validation is required before the checklist passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0a3fa486-7c69-460b-a8e0-c90135b7e498
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.github/workflows/build-target.yml.github/workflows/ci.yml.sampo/changesets/verse8-target-foundation.md.sampo/config.tomlREADME.mdadapters/verse8/package.jsonadapters/verse8/src/index.test.tsadapters/verse8/src/index.tsadapters/verse8/tsconfig.jsondocs/GAME_DEVELOPMENT.mddocs/PUBLIC_RELEASE_CHECKLIST.mdexamples/phaser-starter/agent/brief.template.mdexamples/phaser-starter/agent/game.manifest.jsonexamples/phaser-starter/mpgd.targets.jsonexamples/phaser-starter/package.jsonexamples/phaser-starter/src/platform/buildGateways/verse8.tsexamples/phaser-starter/src/platform/runtimeDetector.tsexamples/phaser-starter/vite.shared.tspackage.jsonpackages/cli/package.jsonpackages/cli/src/index.tspackages/cli/templates/phaser-game/README.mdpackages/cli/templates/phaser-game/agent/brief.mdpackages/cli/templates/phaser-game/agent/game-manifest.jsonpackages/cli/templates/phaser-game/mpgd.targets.jsonpackages/cli/templates/phaser-game/package.jsonpackages/cli/templates/phaser-game/src/platform/buildGateways/verse8.tspackages/cli/templates/phaser-game/src/platform/runtimeDetector.tspackages/cli/templates/phaser-game/vite.shared.tspackages/game-services/src/notification-delivery.test.tspackages/game-services/src/notification-delivery.tspackages/platform/src/index.tspackages/target-config/src/runtime.tspackages/target-config/src/viewport.tspackages/target-config/targets.jsonpackages/target-config/test/target-config-smoke.tstools/smoke/adapter-effective-config.tstools/smoke/build-target-artifacts.tstools/smoke/effective-target-config.tstools/smoke/target-config-runtime.tstools/target/build-target.tstools/target/effective-config.tstools/validate-starter-workflow.tstools/validate-target-config.ts
🚧 Files skipped from review as they are similar to previous changes (29)
- packages/cli/templates/phaser-game/agent/brief.md
- packages/cli/templates/phaser-game/mpgd.targets.json
- packages/cli/templates/phaser-game/src/platform/buildGateways/verse8.ts
- adapters/verse8/tsconfig.json
- examples/phaser-starter/src/platform/buildGateways/verse8.ts
- examples/phaser-starter/agent/game.manifest.json
- .sampo/changesets/verse8-target-foundation.md
- packages/target-config/targets.json
- packages/game-services/src/notification-delivery.ts
- packages/cli/templates/phaser-game/src/platform/runtimeDetector.ts
- examples/phaser-starter/mpgd.targets.json
- adapters/verse8/package.json
- packages/cli/templates/phaser-game/package.json
- .github/workflows/build-target.yml
- packages/cli/package.json
- examples/phaser-starter/src/platform/runtimeDetector.ts
- packages/target-config/src/viewport.ts
- packages/cli/templates/phaser-game/vite.shared.ts
- examples/phaser-starter/agent/brief.template.md
- examples/phaser-starter/package.json
- examples/phaser-starter/vite.shared.ts
- packages/target-config/src/runtime.ts
- packages/cli/templates/phaser-game/agent/game-manifest.json
- tools/target/effective-config.ts
- .github/workflows/ci.yml
- package.json
- tools/validate-starter-workflow.ts
- adapters/verse8/src/index.ts
- adapters/verse8/src/index.test.ts
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
909541f to
299754c
Compare
299754c to
f508e75
Compare
|
Corrected the release registration and checklist in f508e75: the singleton Sampo linked group preserves the requested 0.1.1 patch release, and the public checklist now gates Verse8 build and artifact smoke. Isolated-main Sampo dry-run plus |
|
✅ Action performedReview finished.
|
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
artifacts/verse8production buildRelease
@mpgd/platform,@mpgd/target-config,@mpgd/cli,@mpgd/game-services, and@mpgd/adapter-verse8@mpgd/adapter-verse8@0.1.0registration on npmimjlk/mpgd-kitandrelease.ymlwith publish permissionsValidation
pnpm checkpnpm --filter @mpgd/adapter-verse8 testpnpm --filter @mpgd/adapter-verse8 checkpnpm validate:publicpnpm pack:packagessampo release --dry-runfrom an isolatedmainclonepnpm testpnpm graph:preflightpnpm build:verse8pnpm smoke:target verse8pnpm smoke:targets:build