transpile: Deep comparison of types in make_cast - #1984
Merged
Merged
Conversation
Rua
force-pushed
the
types_eq
branch
4 times, most recently
from
August 25, 2026 12:27
61f67fb to
ed40e9d
Compare
ahomescu
reviewed
Aug 25, 2026
ahomescu
left a comment
ahomescu
left a comment
Contributor
There was a problem hiding this comment.
This could use tests for deep comparisons of both arrays and function pointers.
Rua
force-pushed
the
types_eq
branch
2 times, most recently
from
August 26, 2026 09:00
9a6c60f to
f032a4e
Compare
Contributor
Author
|
I've added tests now for casts for pointers to arrays, and for pointers to functions where either a parameter or the return is a typedef. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for detecting cases where two types should be considered equal at a deeper level. For example,
*const usizevs*const size_tor[usize; N]vs[size_t; N].