Repository navigation
Bump LTO shared lib for C API - #411
Merged
Merged
Conversation
ethanglaser
marked this pull request as ready for review
October 6, 2026 14:55
Member
Author
|
LGTM! |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Returning the dataset by value introduces a full, memory-intensive copy during index conversion.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates C API index conversion and points GCC 11.2 builds to the latest LTO archive.
Changes:
- Returns simple datasets directly during conversion.
- Updates the nightly LTO shared-library URL.
| File | Description |
|---|---|
bindings/c/src/data_builder/simple.hpp |
Changes simple dataset access during conversion. |
bindings/c/CMakeLists.txt |
Bumps the LTO archive URL. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ahuber21
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.