Skip to content

Bump LTO shared lib for C API #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahuber21 merged 6 commits into from
Oct 7, 2026
Merged

Bump LTO shared lib for C API #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f3abb4
Bump LTO shared lib for C API
ethanglaser Oct 5, 2026
d7c40a6
fix: shortcut fix for undefined references ld error
rfsaliev Oct 6, 2026
d75babd
Update SVS URL
rfsaliev Oct 6, 2026
0b638fd
Update SVS URL to 1613
rfsaliev Oct 6, 2026
51525ea
code review fix: return a reference from SimpleDataBuilder::get_datas…
rfsaliev Oct 6, 2026
c66c25a
Merge branch 'main' into dev/eglaser-bump-c-api-lib
ethanglaser Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/c/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ if (SVS_RUNTIME_ENABLE_LVQ_LEANVEC)
else()
# Links to LTO-enabled static library, requires GCC/G++ 11.2
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.2" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.3")
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-lto-nightly-2026-09-11-1512.tar.gz"
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-lto-nightly-2026-10-06-1613.tar.gz"
CACHE STRING "URL to download SVS shared library")
else()
# The fallback is correct but slower, so nothing downstream fails and CI
Expand Down
4 changes: 1 addition & 3 deletions bindings/c/src/data_builder/simple.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ class SimpleDataBuilder {
return total_size;
}

auto get_dataset(const data_type& data) const {
return svs::c_runtime::decompressed_dataset(data, svs::data::GetDatumAccessor{});
}
const data_type& get_dataset(const data_type& data) const { return data; }
};

template <Arithmetic T, typename Alloc>
Expand Down
2 changes: 1 addition & 1 deletion bindings/c/src/dispatcher_dynamic_vamana.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ svs::DynamicVamana copy_dynamic_vamana_index(
svs::data::copy(src_graph.get_data(), graph.get_data());

// Copy/convert the data from the source index to the new data instance
const auto src_data = src_builder.get_dataset(src_index_impl->view_data());
decltype(auto) src_data = src_builder.get_dataset(src_index_impl->view_data());

using allocator_type = typename DstDataBuilder::allocator_type;
using value_type = typename allocator_type::value_type;
Expand Down
2 changes: 1 addition & 1 deletion bindings/c/src/dispatcher_vamana.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ svs::Vamana copy_vamana_index(
svs::data::copy(src_graph.get_data(), graph.get_data());

// Copy/convert the data from the source index to the new data instance
const auto src_data = src_builder.get_dataset(src_index_impl->view_data());
decltype(auto) src_data = src_builder.get_dataset(src_index_impl->view_data());
using value_type = typename DstDataBuilder::allocator_type::value_type;
auto data = dst_builder.build(src_data, pool, allocator_builder.build<value_type>());

Expand Down
Loading