Repository navigation
fix: Get module name from argument when absent in modinfo - #3
Merged
adrianlasota merged 1 commit intoJan 8, 2026
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the driver name was defaulting to "N/A" when module information was absent from modinfo output. The fix ensures that when the driver name cannot be extracted from modinfo, the provided driver_name argument is used instead of a generic "N/A" value.
- Updated the
get_driver_infomethod to use the inputdriver_nameparameter as fallback when name extraction fails - Modified the corresponding test to expect the actual driver name instead of "N/A"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mfd_package_manager/linux.py | Changed fallback value from "N/A" to the input driver_name parameter |
| tests/unit/test_mfd_package_manager/test_linux.py | Updated test assertion to expect the actual driver name instead of "N/A" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hcymerys
approved these changes
Aug 26, 2025
adrianlasota
approved these changes
Aug 26, 2025
mchromin
approved these changes
Oct 29, 2025
lkleinax
force-pushed
the
fix__Get_module_name_from_argument_when_absent_in_modinfo
branch
from
January 8, 2026 10:15
4657c6e to
54e5887
Compare
adrianlasota
approved these changes
Jan 8, 2026
lkleinax
force-pushed
the
fix__Get_module_name_from_argument_when_absent_in_modinfo
branch
from
January 8, 2026 12:13
54e5887 to
c256f3e
Compare
Fixes intel#2 Signed-off-by: Łukasz Kleina <lukaszx.kleina@intel.com>
lkleinax
force-pushed
the
fix__Get_module_name_from_argument_when_absent_in_modinfo
branch
from
January 8, 2026 14:25
c256f3e to
6fe7796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the behavior for retrieving driver information when the driver's name cannot be found in the output. Instead of defaulting to "N/A", the code now falls back to using the provided
driver_nameargument. The related unit test is also updated to reflect this new behavior.Driver info fallback logic:
mfd_package_manager/linux.py, the fallback value fordriver_nameinget_driver_infois changed from "N/A" to the provideddriver_nameargument.Test updates:
tests/unit/test_mfd_package_manager/test_linux.py, the assertion intest_get_driver_info_no_infois updated to expect the fallback to the provided driver name instead of "N/A".