Skip to content

fix: Get module name from argument when absent in modinfo #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianlasota merged 1 commit into from
Jan 8, 2026
Merged

fix: Get module name from argument when absent in modinfo #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mfd_package_manager/linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def get_driver_info(self, driver_name: str) -> "DriverInfo":
name_regex = r"^\s*name:\s+(?P<name>.*)"
version_match = re.search(version_regex, result.stdout, flags=re.MULTILINE)
name_match = re.search(name_regex, result.stdout, flags=re.MULTILINE)
name = name_match.group("name") if name_match is not None else "N/A"
name = name_match.group("name") if name_match is not None else driver_name
version = version_match.group("version") if version_match is not None else "N/A"
return DriverInfo(driver_version=version, driver_name=name)

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_mfd_package_manager/test_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_get_driver_info_no_info(self, manager):
manager._connection.execute_command.return_value = ConnectionCompletedProcess(
args="", stdout=output, return_code=0
)
assert manager.get_driver_info("i40e") == DriverInfo(driver_name="N/A", driver_version="N/A")
assert manager.get_driver_info("i40e") == DriverInfo(driver_name="i40e", driver_version="N/A")

def test_insert_module(self, manager):
manager.insert_module("i40e", "-a")
Expand Down
Loading