[mkwasile]

Update configure_pfc_ndk to distribute bandwidth equally (50/50) across both traffic classes instead of the previous 90/10 split. Update corresponding unit test assertion to match new values.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Dell OS10 NDK PFC configuration to use an even QoS bandwidth split between the first two traffic classes.

Changes:

• Changed configure_pfc_ndk() to create the QoS policy with a [50, 50, 0, 0, 0, 0, 0, 0] bandwidth distribution instead of [90, 10, 0, 0, 0, 0, 0, 0].
• Updated the corresponding unit test assertion to match the new QoS policy parameters.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py	Adjusts unit test expectation for the updated QoS bandwidth split used by NDK PFC configuration.
mfd_switchmanagement/vendors/dell/dell_os10/base.py	Changes the QoS policy bandwidth weights applied during configure_pfc_ndk() from 90/10 to 50/50.

Comments suppressed due to low confidence (1)

mfd_switchmanagement/vendors/dell/dell_os10/base.py:1

• The docstring for configure_pfc_ndk doesn’t describe the QoS policy it applies (e.g., which TCs are affected and the intended bandwidth split). Since this PR changes behavior from 90/10 to 50/50, documenting the expected policy at a high level (and why) would reduce ambiguity for operators and future maintainers.

# Copyright (C) 2025 Intel Corporation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.