Skip to content

fix: set NDK PFC bandwidth to 50% per traffic class #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianlasota merged 1 commit into from
Jun 10, 2026
Merged

fix: set NDK PFC bandwidth to 50% per traffic class #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mfd_switchmanagement/vendors/dell/dell_os10/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ def configure_pfc_ndk(self, port: str) -> None:

:param port: port of switch
"""
self.create_qos_policy([90, 10, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100")
self.create_qos_policy([50, 50, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100")
Comment thread
mkwasile marked this conversation as resolved.
Resolved
self.set_port_bw_by_tc(port, suffix="100")
self.set_port_pfc_by_tc(port, qos_priority=None, pfc="on")
self.set_port_dcbx_version(port, mode="ieee")
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ def test_configure_pfc_ndk(self, switch, mocker):
switch.configure_pfc_ndk(port)

# Assert
switch.create_qos_policy.assert_called_once_with([90, 10, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100")
switch.create_qos_policy.assert_called_once_with([50, 50, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100")
switch.set_port_bw_by_tc.assert_called_once_with(port, suffix="100")
switch.set_port_pfc_by_tc.assert_called_once_with(port, qos_priority=None, pfc="on")
switch.set_port_dcbx_version.assert_called_once_with(port, mode="ieee")
Expand Down
Loading