memcache - chore: defense - lint workflows with zizmor - #116
Merged
Conversation
Add check-workflows.yaml and clear the findings it would fail on: persist-credentials: false on checkouts that do not push, and package-manager-cache: false on publish/deploy setup-node steps. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1399 1399
Branches 308 308
=========================================
Hits 1399 1399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaredwray
marked this pull request as ready for review
August 18, 2026 17:06
2 tasks
jaredwray
added a commit
that referenced
this pull request
Aug 18, 2026
* chore: defense - stage npm releases instead of publishing live Pack a tarball and run pnpm stage publish so CI can only stage; a maintainer still has to promote. Reconcile zizmor items as merged in PR #116. Co-authored-by: Jared Wray <me@jaredwray.com> * chore: defense - record PR #117 on stage-publish checklist Co-authored-by: Jared Wray <me@jaredwray.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lint GitHub Actions workflows with zizmor on every PR, and apply the settings zizmor requires so the job can pass.
Status update
DEFENSE_IN_DEPTH.md: § 4 zizmor → (PR #116 pending); persist-credentials → (PR #116 pending); publish-job cache disable → (PR #116 pending); SHA pinning → PR #113 (merged)Changes
.github/workflows/check-workflows.yaml(zizmor-action v0.6.2, Socket Firewall,permissions: {})persist-credentials: falseon every checkout that does not pushpackage-manager-cache: falseonsetup-nodeinrelease.yamlanddeploy-site.yamlSECURITY.mdLocal
zizmor 1.29.0reports no findings (21 suppressed). Regular test/coverage jobs still cache pnpm.Verification
zizmor .github/workflows— no findingsnpx actions-up --yes --style sha— already up to dateReference
defense-in-depth-nodejs § 4