Skip to content

fix: show task log errors and allow retry - #437

Merged
lixd merged 1 commit into
kubeclipper:masterfrom
lixd:fix/operation-log-request-error
Oct 22, 2026
Merged

lixd merged 1 commit into
kubeclipper:masterfrom
lixd:fix/operation-log-request-error

Conversation

@lixd

@lixd lixd commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

When a V2 task log request fails, the log panel can remain on a spinner with no way to recover. End loading on failure, show an explicit error and a reload button, and preserve the received log bytes and offset so reloading can resume without losing or duplicating output. Normal initial loading and periodic log updates use the same error handling.

Which issue(s) this PR fixes:

Found during browser regression against the OCI backend; no linked issue.

Special notes for reviewers:

  • Three new unit regressions failed before the fix and pass afterward, including interruption of a partially delivered log and resuming from its saved offset. Full suite: 9 suites / 53 tests passed.
  • Production build with ADD_WORKLOAD=true, Prettier, and whitespace checks passed. ESLint has zero errors and the two existing hook dependency warnings in the log component.
  • Live browser regression used an isolated OCI server/Agent at backend commit 13ced73ddf30ee48cc550321383f76c9be124e8a. Stopping the temporary Agent produced a real log API ServiceUnavailable response and an explicit error panel. Restarting the Agent and clicking reload in the same dialog restored the real task log. Successful/failed task logs and node IP display also passed.
  • Node SSH and Kubernetes kubectl terminal command I/O and remote PTY resize were verified through that OCI backend. The kubectl case used an existing running Kubernetes cluster; it does not qualify OCI cluster provisioning. Temporary processes, credentials and metadata were removed after testing.

Does this PR introduced a user-facing change?

Task log panels now show request failures and allow reloading logs instead of remaining on a loading spinner.

Additional documentation, usage docs, etc.:

None.

Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
lixd force-pushed the fix/operation-log-request-error branch from ee546cf to 43d568f Compare October 22, 2026 07:31
@lixd
lixd merged commit c84dcb8 into kubeclipper:master Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant