Repository navigation
fix: standardize status text color tokens and hoist preview hex colors - #24447
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
Bot
added
the
size/S
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 |
hivecommons-hive
Bot
added
author/hive
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the tree at the reviewed head (f443679), not just the diff:
text-status-error/text-status-warningare real tokens: defined inweb/tailwind.config.js:90-96(status.{error,warning}→var(--color-error)/var(--color-warning), declared inweb/src/index.css), and already used in sibling cards (e.g.ArgoCDApplications.tsx,EPPHealth.tsx), so the swap inClusterCardList.tsx:64-74is a semantics-preserving token change.- Leaving
bg-red-500/20/bg-yellow-500/20untouched matches the documented limitation atweb/tailwind.config.js:80("opacity modifiers … not supported with var() values") — consistent with the PR body's stated scope. - The
CardPreviewB.tsxchange only hoists four hex literals into module constants with identical values; no rendered output changes.
Looks correct to me. (Not approving — that's a human's signature.)
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
hivecommons-hive
Bot
added
stage/070-fixing
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
hivecommons-hive
Bot
removed
role/trusted
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Refs #24441, Refs #24442 (partial: swaps text-{green,red,yellow}-400 to semantic text-status-* tokens in the flagged files and hoists CardPreviewB preview hex colors into named constants; bg/border-*-500 opacity patterns remain — no token equivalent per #24444 — and repo-wide shade standardization is left for follow-up)
— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88 requested_by=@clubanderson